-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate landscape css to tikui #3970
Comments
Sorry, I'm a bit late to answer because i'm busy this week until monday. I just want to say that I'm currently on this migration but with a different approach, by creating small components and by composing them using atomic design. (That's why there is some atoms already presents). My other approach is to make a light theme instead of the dark theme (you can see it's not dark in the pattern library) I'm also working with @ascelineboullen for this, that's also why I've not started the past week. Sure we need help about style, maybe it could be interesting to make less coupled issues (maybe some smaller issues to design existing components with the design from Asceline also). Don't know what you think @pascalgrimaud and @nassimerrahoui (following the PR #4065)? I also link #3969 because the style is similar for some parts. The main issue to fallow all of this are on #2894 |
I haven't started the ticket too much so I can close my PR |
There isn't css at .vue file. Should it be close? |
Maybe it's done, let's close this |
The landscape css partly remains in the .vue file. Should be put in tikui
The text was updated successfully, but these errors were encountered: