Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is src/test/webapp/component/**/*.ts ts configfr exlusion usefull? #10925

Closed
DamnClin opened this issue Sep 20, 2024 · 4 comments · Fixed by #11161
Closed

Is src/test/webapp/component/**/*.ts ts configfr exlusion usefull? #10925

DamnClin opened this issue Sep 20, 2024 · 4 comments · Fixed by #11161

Comments

@DamnClin
Copy link
Collaborator

In tsconfig for vue app there is an exclusion for "src/test/webapp/component/**/*.ts", is this still usefull?

@renanfranca
Copy link
Contributor

Hello @DamnClin ,

I would like to take this opportunity in our discussion to ask how files that do not have 100% test coverage should be excluded.

For instance, if you look at this comment regarding the files I will add with the vue-oauth2-keycloak module. What I thought was to add each file individually as an exclusion. What do you think?

@DamnClin
Copy link
Collaborator Author

Hello @DamnClin ,

I would like to take this opportunity in our discussion to ask how files that do not have 100% test coverage should be excluded.

For instance, if you look at this comment regarding the files I will add with the vue-oauth2-keycloak module. What I thought was to add each file individually as an exclusion. What do you think?

This is not a coverage exclusion but a build exclusion :).

For coverage exclusion my take is: as long as we can't get a proper merge we should remove this metric. I think not metric is better than a wrong one

@renanfranca
Copy link
Contributor

Hello @DamnClin ,
I would like to take this opportunity in our discussion to ask how files that do not have 100% test coverage should be excluded.
For instance, if you look at this comment regarding the files I will add with the vue-oauth2-keycloak module. What I thought was to add each file individually as an exclusion. What do you think?

This is not a coverage exclusion but a build exclusion :).

Oh, my bad!

For coverage exclusion my take is: as long as we can't get a proper merge we should remove this metric. I think not metric is better than a wrong one

Should we remove the code coverage 100% metric from the frontend generated apps?

@renanfranca
Copy link
Contributor

For coverage exclusion my take is: as long as we can't get a proper merge we should remove this metric. I think not metric is better than a wrong one

Should we remove the code coverage 100% metric from the frontend generated apps?

@DamnClin : as this code coverage discussion is not the main topic of this issue, I created a discussion here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants