-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bug) build fails on windows with autocrlf=lf #10463
base: main
Are you sure you want to change the base?
fix(bug) build fails on windows with autocrlf=lf #10463
Conversation
Changing end of file and properties String manipulation to use Properties class close jhipster#10398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some doubts on that. Does this keep the other parts of the file intact (not changing order, not deleting blank lines etc)???
No it does not, and I didn't think it should since there was no test for this :/ Order should be preserved, but empty lines will definitly go away. If those points are mandatory behaviours for the component, they should be tested accordingly beforehand |
For me they are, we learned that later on but I think this is really important. @pascalgrimaud any advice on this? |
IMO these points are indeed mandatory. |
Changing end of file and properties String manipulation to use Properties class
close #10398