Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @angular-eslint/eslint-plugin from 17.5.2 to 18.0.1 in /generators/angular/resources in the angular-eslint group across 1 directory #26320

Closed
wants to merge 1 commit into from
Closed

Bump @angular-eslint/eslint-plugin from 17.5.2 to 18.0.1 in /generators/angular/resources in the angular-eslint group across 1 directory #26320

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 31, 2024 •
edited
Loading

Bumps the angular-eslint group with 1 update in the /generators/angular/resources directory: @angular-eslint/eslint-plugin.

Updates @angular-eslint/eslint-plugin from 17.5.2 to 18.0.1

Release notes

Sourced from @​angular-eslint/eslint-plugin's releases.

v18.0.1

18.0.1 (2024-05-30)

🩹 Fixes

  • move typescript-eslint packages to peerDeps, consistently allow v7 and v8 (#1856)

As part of the v18 release, support for typescript-eslint v8 prereleases was added. For authors of custom rules that consume the @angular-eslint/utils or new @angular-eslint/test-utils packages, the initial way this was set up with dependencies could cause type conflicts between v7 and v8. To resolve this the @angular-eslint/* packages now depend on @typescript-eslint/* packages via a peerDependency which permits both v7 and v8 prereleases.

❤️ Thank You

v18.0.0

18.0.0 (2024-05-29)

As always we recommend that you update your existing workspaces by using ng update as we provide some helpful schematics to help migrate your workspaces to the latest and greatest. Running the following will update Angular, the Angular CLI and angular-eslint together:

ng update @angular/core @angular/cli @angular-eslint/schematics

NOTE: There will not be any migration of your setup to ESLint v9 or flat configs for existing workspaces in v18.

The ESLint team are working on auto-migrate tooling which we will leverage in an opt-in conversion generator once it is ready in a v18 minor release and consider full auto-migration in v19 in six months (aligned with Angular major release schedule as always).

If you want to manually migrate your workspace to use ESLint v9, typescript-eslint v8, and flat config you are welcome to and it should be fully supported in v18.

If you are going to attempt this, we strongly recommended creating a fresh Angular v18 workspace and adding angular-eslint to it per the instructions below and then copying the dependencies and configs that it applies into your existing workspace

Here is an example of what the new flat config with angular-eslint v18, typescript-eslint v8, and ESLint v9 looks like:

image

Adding to New Angular Workspaces in v18

There is a decision to be made when adding to new Angular v18 workspaces.

Just as before, if you want to add angular-eslint to a workspace with no existing lint setup, you leverage ng add with the @angular-eslint/schematics package.

The difference is in v18, you have the option of using either:

  • the latest version of ESLint v9, with the latest default so called "flat config" (eslint.config.js) alongside the latest prerelease of typescript-eslint v8 (https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta) OR
  • the final stable version of ESLint v8, with the legacy so called "eslintrc" config (.eslintrc.json) and the latest stable version of typescript-eslint v7

The ESLint v9 option is the default scenario if you simply run ng add with no other changes. If you want to signal to angular-eslint that you instead want to go with the ESLint v8 option, simply add an eslint v8 (the exact version does not matter, it just needs to be less than 9) devDependency in your package.json before running the ng add. That's it - you don't even need to install the eslint package, it just needs to be listed there.

... (truncated)

Changelog

Sourced from @​angular-eslint/eslint-plugin's changelog.

18.0.1 (2024-05-30)

🩹 Fixes

  • move typescript-eslint packages to peerDeps, consistently allow v7 and v8

❤️ Thank You

  • James Henry

18.0.0 (2024-05-29)

🚀 Features

  • ⚠️ angular-eslint v18

⚠️ Breaking Changes

  • ⚠️ angular-eslint v18

❤️ Thank You

  • James Henry
Commits
  • f36d027 chore(release): publish 18.0.1
  • fd69e8e fix: move typescript-eslint packages to peerDeps, consistently allow v7 and v...
  • c8dff2f chore(release): publish 18.0.0
  • 7c84ab7 feat!: angular-eslint v18 (#1830)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added skip-changelog Exclude pull requests from the release notes theme: angular theme: dependencies Pull requests that update a dependency file labels May 31, 2024
@dependabot dependabot bot mentioned this pull request May 31, 2024
Closed
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/generators/angular/resources/angular-eslint-06b4441ef9 branch 6 times, most recently from e102c39 to 919ccd9 Compare June 10, 2024 03:11
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/generators/angular/resources/angular-eslint-06b4441ef9 branch 4 times, most recently from 51a7286 to 53a3c93 Compare June 14, 2024 04:01
@dependabot
Bump @angular-eslint/eslint-plugin
180fa76 
Bumps the angular-eslint group with 1 update in the /generators/angular/resources directory: [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/eslint-plugin).


Updates `@angular-eslint/eslint-plugin` from 17.5.2 to 18.0.1
- [Release notes](https://github.com/angular-eslint/angular-eslint/releases)
- [Changelog](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/angular-eslint/angular-eslint/commits/v18.0.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@angular-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: angular-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/generators/angular/resources/angular-eslint-06b4441ef9 branch from 53a3c93 to 180fa76 Compare June 17, 2024 03:42
@DanielFran
Copy link
Member

Superseded by #26213

@DanielFran DanielFran closed this Jun 17, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 17, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/generators/angular/resources/angular-eslint-06b4441ef9 branch June 17, 2024 12:32
@mraible mraible added this to the 8.6.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-changelog Exclude pull requests from the release notes theme: angular theme: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielFran @mraible