spring-data-relational blueprint test failure #25391

dwarakaprasad · 2024-03-03T16:25:32Z

Overview of the issue

spring-data-blueprint test fails with the following exception,

FAIL  generators/spring-data-relational/generator.spec.mjs > SubGenerator spring-data-relational of basepack JHipster blueprint > run
ReferenceError: /home/dwarka/develop/code/brmaStr/basepack/jhipster-basepack/node_modules/generator-jhipster/dist/generators/spring-data-relational/templates/src/main/java/_package_/config/DatabaseConfiguration.java.ejs:90
   88| @EnableR2dbcRepositories({<%- domains.map(domain => `"${domain}.repository"`).join(', ') %>})
   89| <%_ } else { _%>
>> 90| @EnableJpaRepositories({<%- domains.map(domain => `"${domain}.repository"`).join(', ') %>})
   91| @EnableJpaAuditing(auditorAwareRef = "springSecurityAuditorAware")
   92| <%_ } _%>
   93| @EnableTransactionManagement

domains is not defined
❯ default.eval "/home/dwarka/develop/code/brmaStr/basepack/jhipster-basepack/node_modules/generator-jhipster/dist/generators/spring-data-relational/templates/src/main/java/_package_/config/DatabaseConfiguration.java.ejs":92:17
❯ DatabaseConfiguration.java node_modules/ejs/lib/ejs.js:703:17
❯ node_modules/ejs/lib/ejs.js:260:40
❯ tryHandleCache node_modules/ejs/lib/ejs.js:258:14
❯ Object.exports.renderFile node_modules/ejs/lib/ejs.js:491:10
❯ renderFile node_modules/mem-fs-editor/dist/util.js:65:16
❯ MemFsEditor.processFile node_modules/mem-fs-editor/dist/actions/copy-tpl-async.js:13:20
❯ MemFsEditor.applyProcessingFileFunc node_modules/mem-fs-editor/dist/actions/copy-async.js:10:54
❯ MemFsEditor._copySingleAsync node_modules/mem-fs-editor/dist/actions/copy-async.js:76:52

Motivation for or Use Case

It should be possible to extend spring-data-relational generator.

Reproduce the error

use the attached .yo-rc.json to generate a blueprint and you can see the failure.

Related issues

none

Suggest a Fix

JHipster Version(s)

8.1.0

JHipster configuration

.yo-rc.json file

{
  "generator-jhipster": {
    "additionalSubGenerators": "",
    "baseName": "basepack",
    "cli": true,
    "entities": [],
    "generators": {
      "spring-cloud-stream": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-cassandra": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-couchbase": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-elasticsearch": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-mongodb": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-neo4j": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-data-relational": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      },
      "spring-websocket": {
        "command": true,
        "priorities": [
          "initializing",
          "prompting",
          "configuring",
          "composing",
          "loading",
          "preparing",
          "configuringEachEntity",
          "loadingEntities",
          "preparingEachEntity",
          "preparingEachEntityField",
          "preparingEachEntityRelationship",
          "postPreparingEachEntity",
          "default",
          "writing",
          "writingEntities",
          "postWriting",
          "postWritingEntities",
          "loadingTranslations",
          "install",
          "postInstall",
          "end"
        ],
        "sbs": false,
        "written": true
      }
    },
    "jhipsterVersion": "8.1.0",
    "localBlueprint": false,
    "sampleWritten": true,
    "skipCommitHook": true,
    "subGenerators": [
      "spring-cloud-stream",
      "spring-data-cassandra",
      "spring-data-couchbase",
      "spring-data-elasticsearch",
      "spring-data-mongodb",
      "spring-data-neo4j",
      "spring-data-relational",
      "spring-websocket"
    ]
  }
}

Environment and Tools

openjdk version "17.0.8" 2023-07-18
OpenJDK Runtime Environment Temurin-17.0.8+7 (build 17.0.8+7)
OpenJDK 64-Bit Server VM Temurin-17.0.8+7 (build 17.0.8+7, mixed mode, sharing)

git version 2.34.1

node: v18.19.0
npm: 10.2.3

Docker version 25.0.3, build 4debf41

JDL for the Entity configuration(s) `entityName.json` files generated in the `.jhipster` directory

JDL entity definitions

Entity configuration(s) `entityName.json` files generated in the `.jhipster` directory

Browsers and Operating System

Checking this box is mandatory (this is just to show you read everything)

The text was updated successfully, but these errors were encountered:

fixes jhipster#25391

mshima · 2024-03-03T21:28:44Z

This part can be moved to Java generator:

generator-jhipster/generators/server/generator.js

Lines 564 to 568 in a2a4016

    
           loadDomains({ application, entities }) { 
        
             application.domains = [ 
        
               ...new Set([application.packageName, ...entities.map(entity => entity.entityAbsolutePackage).filter(Boolean)]), 
        
             ]; 
        
           },

and the relational generator can depend on Java or spring-boot

generator-jhipster/generators/spring-data-relational/generator.ts

Line 48 in 4d8ad04

await this.dependsOnJHipster(GENERATOR_BOOTSTRAP_APPLICATION);

dwarakaprasad · 2024-03-05T18:13:25Z

yup thanks for your review, will update.

dwarakaprasad · 2024-03-06T00:16:32Z

This part can be moved to Java generator:

generator-jhipster/generators/server/generator.js

Lines 564 to 568 in a2a4016

loadDomains({ application, entities }) {

application.domains = [

...new Set([application.packageName, ...entities.map(entity => entity.entityAbsolutePackage).filter(Boolean)]),

];

},

and the relational generator can depend on Java or spring-boot

generator-jhipster/generators/spring-data-relational/generator.ts

Line 48 in 4d8ad04

await this.dependsOnJHipster(GENERATOR_BOOTSTRAP_APPLICATION);

Done

…on server (#25392) * modify spring-data-relational spec to run server generator fixes #25391 * modify spring-data-relational spec to run server generator fixes #25391 * add spring-boot dependency to spring-data-relational & refactor default priority * refactor spring-data-relation dependency * Apply suggestions from code review * drop load domains from server --------- Co-authored-by: Marcelo Shima <[email protected]>

github-actions bot added area: triage theme: undefined labels Mar 3, 2024

dwarakaprasad added a commit to dwarakaprasad/generator-jhipster that referenced this issue Mar 3, 2024

modify spring-data-relational spec to run server generator

0b84eff

fixes jhipster#25391

dwarakaprasad added a commit to dwarakaprasad/generator-jhipster that referenced this issue Mar 3, 2024

modify spring-data-relational spec to run server generator

79f96ad

fixes jhipster#25391

dwarakaprasad mentioned this issue Mar 3, 2024

Move load domains logic to java generator and make relational depend on server #25392

Merged

6 tasks

mshima closed this as completed in #25392 Mar 7, 2024

deepu105 added this to the 8.2.0 milestone Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

spring-data-relational blueprint test failure #25391

spring-data-relational blueprint test failure #25391

dwarakaprasad commented Mar 3, 2024

mshima commented Mar 3, 2024

dwarakaprasad commented Mar 5, 2024

dwarakaprasad commented Mar 6, 2024

spring-data-relational blueprint test failure #25391

spring-data-relational blueprint test failure #25391

Comments

dwarakaprasad commented Mar 3, 2024

Overview of the issue

Motivation for or Use Case

Reproduce the error

Related issues

Suggest a Fix

JHipster Version(s)

JHipster configuration

Environment and Tools

JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory

Entity configuration(s) entityName.json files generated in the .jhipster directory

Browsers and Operating System

mshima commented Mar 3, 2024

dwarakaprasad commented Mar 5, 2024

dwarakaprasad commented Mar 6, 2024

JDL for the Entity configuration(s) `entityName.json` files generated in the `.jhipster` directory

Entity configuration(s) `entityName.json` files generated in the `.jhipster` directory