Sonar: Unnecessary use of conditional expression for default assignment

[qmonmert]

https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=CODE_SMELL&id=jhipster-sample-application&open=AY1qKP6qZqAZOZp0Vj8m

These two solutions don't work:
return { predicate: sortParam };
or
return { predicate: sortParam ?? undefined };

Indeed this test is in error:

    it('should accept empty string', () => {
      const sortState = service.parseSortParam('');
      expect(sortState).toEqual({});
    });

A solution which fixes sonar is:
return { predicate: (sortParam && sortParam !== '') ? sortParam : undefined };
but sortParam !== '' is useless.

Maybe add a NOSONAR ...

WDYT @mshima ?

Test:

[mshima]

return { predicate: sortParam || undefined };?

[qmonmert]

nope 🙂

[mshima]

return { predicate: Boolean(sortParam) ? sortParam : undefined };
return { predicate: sortParam?.length ? sortParam : undefined };
return { predicate: sortParam !== undefined && sortParam.length > 0 ? sortParam : undefined };
return { predicate: (sortParam ?? '').length > 0 ? sortParam : undefined };

if (sortParam) {
  return { predicate: sortParam };
}
return {};

[qmonmert]

return { predicate: sortParam?.length ? sortParam : undefined }; seems good