Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French is auto-selected when choosing additional languages #24125

Closed
mraible opened this issue Nov 7, 2023 · 4 comments · Fixed by #24181
Closed

French is auto-selected when choosing additional languages #24125

mraible opened this issue Nov 7, 2023 · 4 comments · Fixed by #24181

Comments

@mraible
Copy link
Contributor

mraible commented Nov 7, 2023

Overview of the issue

I was updating one of my tutorials this evening, and I noticed that French is pre-selected when you're prompted for additional languages.

Screenshot 2023-11-06 at 9 36 02 PM
Motivation for or Use Case

In previous versions, we did not pre-select any additional languages.

Reproduce the error

Create a new app with v8 and the jhipster command.

JHipster Version(s)

8.0.0

@mraible
Copy link
Contributor Author

mraible commented Nov 7, 2023

I just noticed that even if I de-select French and select Spanish, French is still selected and written to .yo-rc.json.

"languages": ["en", "fr", "es"],

Is this an Easter Egg from @jdubois ?! 😅

Screenshots for proof:

Screenshot 2023-11-06 at 9 47 37 PM Screenshot 2023-11-06 at 9 47 57 PM

@jdubois
Copy link
Member

jdubois commented Nov 7, 2023

Ah ah no I have no idea why this happens! Then as I'm testing with French, it probably explains why I haven't noticed it.

@mraible
Copy link
Contributor Author

mraible commented Nov 10, 2023

I'd like to see this fixed before 8.0.1 because it seems like a blocker for my JHipster 8 blog tutorial and screencast.

I searched for a .yo-rc.json in my home directory and in the parent directory but didn't find anything. Can anyone else reproduce?

@mshima mshima mentioned this issue Nov 10, 2023
6 tasks
@mshima
Copy link
Member

mshima commented Nov 10, 2023

The bug is that we are adding a non-selected language.
Bringing 'en' and 'fr' as additional languages is currently the correct behavior unless we decide to don't add any additional language if i18n is enabled.

options[LANGUAGES] = ['en', 'fr'];

Translation enabled with only one language is quite useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants