Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: wrong labels in Account menu when signed in #20361

Closed
1 task done
moritzreiter opened this issue Nov 17, 2022 · 1 comment
Closed
1 task done

React: wrong labels in Account menu when signed in #20361

moritzreiter opened this issue Nov 17, 2022 · 1 comment

Comments

@moritzreiter
Copy link

Overview of the issue

The Account menu shows wrong labels for the first two items when logged in. They say Sign in and Register (as if not being signed in) but they should actually say Settings and Password.

Interestingly, after switching the language, the correct labels get displayed, but then, when reloading the page via the browser, the incorrect labels get displayed again.

Here's a video to illustrate the behavior more clearly:
jhipster-react-bug

I see this behavior in a newly generated monolith with React frontend without making any changes to the code.

Motivation for or Use Case

The menu should always display the correct labels.

Reproduce the error

Generate a monolith with React frontend, sign in and look at the labels in the Account menu.

Related issues

Didn't find any.

Suggest a Fix

I guess it's probably a problem in the React code for the Account menu (src/main/webapp/app/shared/layout/menus/account.tsx), that's all I can say right now.

JHipster Version(s)

Most recent stable release: 7.9.3.

JHipster configuration
.yo-rc.json file
{
  "generator-jhipster": {
    "applicationType": "monolith",
    "authenticationType": "jwt",
    "baseName": "rdm",
    "blueprints": [],
    "buildTool": "gradle",
    "cacheProvider": "ehcache",
    "clientFramework": "react",
    "clientPackageManager": "npm",
    "clientTheme": "solar",
    "clientThemeVariant": "dark",
    "creationTimestamp": 1668585284659,
    "cypressAudit": true,
    "cypressCoverage": null,
    "databaseType": "sql",
    "devDatabaseType": "postgresql",
    "devServerPort": 9060,
    "dtoSuffix": "DTO",
    "enableGradleEnterprise": false,
    "enableHibernateCache": true,
    "enableSwaggerCodegen": true,
    "enableTranslation": true,
    "entitySuffix": "",
    "jhiPrefix": "jhi",
    "jhipsterVersion": "7.9.3",
    "jwtSecretKey": "YourJWTSecretKeyWasReplacedByThisMeaninglessTextByTheJHipsterInfoCommandForObviousSecurityReasons",
    "languages": ["en", "de"],
    "messageBroker": false,
    "microfrontend": false,
    "microfrontends": [],
    "nativeLanguage": "en",
    "otherModules": [],
    "packageName": "com.foo.rdm",
    "pages": [],
    "prodDatabaseType": "postgresql",
    "reactive": false,
    "searchEngine": false,
    "serverPort": "8080",
    "serverSideOptions": ["enableSwaggerCodegen:true"],
    "serviceDiscoveryType": "no",
    "skipCheckLengthOfIdentifier": false,
    "skipClient": false,
    "skipFakeData": false,
    "skipUserManagement": false,
    "testFrameworks": ["cypress"],
    "websocket": false,
    "withAdminUi": true
  }
}
Entity configuration(s) entityName.json files generated in the .jhipster directory

No Entities generated.

Browsers and Operating System
  • macOS 13.0.1

  • Chrome 107.0.5304.110 and

  • Safari 16.1

  • Checking this box is mandatory (this is just to show you read everything)

@qmonmert
Copy link
Contributor

This bug was fixed since few months I think.

I don't reproduce

cc @DanielFran @mshima

@mshima mshima closed this as completed Dec 27, 2023
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants