Skip to content

Commit 9322e10

Browse files
committed
Merge branch 'master' into update-rndebugger-open
2 parents 8a09137 + b5bb1c6 commit 9322e10

File tree

4 files changed

+5
-18
lines changed

4 files changed

+5
-18
lines changed

__e2e__/app.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('Application launch', () => {
9292

9393
await waitForExpect(async () => {
9494
expect(await mainWindow.title()).toBe(
95-
`React Native Debugger - Waiting for client connection (port ${customRNServerPort})`,
95+
'React Native Debugger - Waiting for client connection (port 8081)',
9696
);
9797
});
9898
server.close();

app/containers/App.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export default class App extends Component {
166166
button="Confirm"
167167
inputProps={{
168168
type: 'input',
169-
value: 19001,
169+
value: 19000,
170170
}}
171171
onInputChange={value => Number(value.replace(/\D/g, '').substr(0, 5)) || ''}
172172
onSubmit={this.handlePortOnSubmit}

npm-package/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ $ REACT_DEBUGGER="rndebugger-open --open --port 8081" npm start
4747
$ set REACT_DEBUGGER="rndebugger-open --open --port 8081" && npm start
4848
```
4949

50+
If you're using Expo <= 48, use port 19000 instead of 8081.
51+
5052
#### Options (--option)
5153

5254
Name | Description
@@ -55,7 +57,6 @@ Name | Description
5557
`revert` | Revert rndebugger-open injection. Default is `false`
5658
`open` | Run open directly instead of inject patch
5759
`port` | Specified react-native packager port with `--open` option. Default is `8081`
58-
`expo` | Use [Expo](https://github.com/expo)'s RN packager port if you're not specified port.
5960

6061
You can also [`Launch by CLI or React Native packager`](https://github.com/jhen0409/react-native-debugger/blob/master/docs/getting-started.md#launch-by-cli-or-react-native-packager-macos-only) instead of this package.
6162

npm-package/bin/rndebugger-open.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,7 @@
22

33
'use strict';
44

5-
const fs = require('fs');
6-
const path = require('path');
7-
85
const defaultPort = 8081;
9-
const expoDefaultPort = 19001;
10-
11-
const expoInfoPath = path.join(process.cwd(), '.expo/packager-info.json');
12-
13-
/* eslint-disable global-require */
14-
const getExpoPort = () =>
15-
(fs.existsSync(expoInfoPath)
16-
? require(expoInfoPath).packagerPort || expoDefaultPort
17-
: expoDefaultPort);
186

197
const argv = require('minimist')(process.argv.slice(2), {
208
boolean: [
@@ -26,8 +14,6 @@ const argv = require('minimist')(process.argv.slice(2), {
2614
'macos',
2715
// Open directly instead of Inject code
2816
'open',
29-
// Use expo packager port (getExpoPort) instead of RN packager default port (8081)
30-
'expo',
3117
],
3218
string: ['port', 'host'],
3319
default: {
@@ -36,7 +22,7 @@ const argv = require('minimist')(process.argv.slice(2), {
3622
});
3723

3824
let moduleName;
39-
argv.port = Number(argv.port) || (argv.expo ? getExpoPort() : defaultPort);
25+
argv.port = Number(argv.port) || defaultPort;
4026
if (argv.open && (argv.port || argv.host)) {
4127
moduleName = '../lib/open';
4228
} else {

0 commit comments

Comments
 (0)