Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a background transmit queue for Writer. #246

Open
jhelovuo opened this issue Mar 9, 2023 · 2 comments
Open

Implement a background transmit queue for Writer. #246

jhelovuo opened this issue Mar 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jhelovuo
Copy link
Owner

jhelovuo commented Mar 9, 2023

Currently, sending fragmented data pushes a large number of messages to sending UDP socket. This may block due to kernel send buffer limit. The Messages to be sent should be queued inside Writer, or actually only handles to messages (Timestamp) and other send parameters (unicast/multicast) should be queued. DATA/DATAFRAG messages should be generated from DDSCache by the transmitter queue processor. This should be a timed event in Writer, or better yet, mio-polled write readiness of the sending socket.

This should also eliminate duplicate code from Writer, specifically in sending new samples from DataWriter and sending samples in response to ACKNACK.

@jhelovuo jhelovuo added enhancement New feature or request good first issue Good for newcomers labels Mar 9, 2023
@jd509
Copy link

jd509 commented Mar 13, 2023

Hey @jhelovuo ! Would adding a polling function to poll from the queue with a timeout help for the same?

@jhelovuo
Copy link
Owner Author

I do not understand your suggestion. Please elaborate.

@jhelovuo jhelovuo removed the good first issue Good for newcomers label Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants