Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle failing discovery on unsupported servers #6

Closed
norayr opened this issue Sep 22, 2020 · 8 comments
Closed

Properly handle failing discovery on unsupported servers #6

norayr opened this issue Sep 22, 2020 · 8 comments
Labels
android bug Something isn't working upstream

Comments

@norayr
Copy link

norayr commented Sep 22, 2020

sorry if opening an issue is not a right way to deal with this.
you can close it then.

so, i have tried it wtih two jids - one at spyurk.am, other at joindiaspora.com.
after entering jid on the first screen, i see the continuously loading screen, forever.

os: lineageos-17.1, it is android 10

@jhass
Copy link
Owner

jhass commented Sep 22, 2020

https://version.diaspora.social/spyurk.am

The pod runs on 0.7.14.0.

https://version.diaspora.social/joindiaspora.com

The pod runs on 0.7.14.0.

README.md:

This is still in preview. You will need a pod on the latest develop branch.

I guess the error handling around this could be better though :)

@norayr
Copy link
Author

norayr commented Sep 22, 2020

oh probably the dev branch contains client api?
then close the thread. (:

@jhass
Copy link
Owner

jhass commented Sep 22, 2020

oh probably the dev branch contains client api?

Yeah exactly. Let me dig into why it gets stuck though, will be useful for the transition phase after the release to get this right :)

@jhass jhass added the bug Something isn't working label Sep 22, 2020
@jhass jhass added the upstream label Oct 5, 2020
@jhass
Copy link
Owner

jhass commented Oct 5, 2020

Required upstream fix to properly handle this: openid/AppAuth-Android#611

jhass pushed a commit that referenced this issue Oct 10, 2020
@tclaus
Copy link
Collaborator

tclaus commented Nov 10, 2020

Looks much better with #22 Timeout was originally set tp 60sec with seems to be almost infinite. You'll get a error message either a nice 'timeout' or a hint that pod does not run a v0.8 pod. (Which is currently in beta stage)
@jhass request to close this issue?

@jhass
Copy link
Owner

jhass commented Nov 10, 2020

No, I want to change the message and more properly detect this case (well, that's likely covered by #22 then) once upstream is fixed to allow to do so.

@jhass
Copy link
Owner

jhass commented Nov 10, 2020

Timeout was originally set to 60sec

Quite OT here, but I can tell you from four years of professional app development that a connection latency of 30 seconds or more is not unseen on mobile networks, especially as the user is roaming between cells (= walking or driving around).

@jhass jhass changed the title after entering jid, loads smth "infinitely" Properly handle failing discovery on unsupported servers Nov 16, 2020
@jhass jhass added the android label Nov 16, 2020
@tclaus
Copy link
Collaborator

tclaus commented Oct 23, 2022

spyurk.am (now) runs on 7.99 dev branch and should support this App. As v1.0.0 looms on the horizon it is unlikely that unsupported pods will be supported in insporation.

@tclaus tclaus closed this as completed Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

3 participants