-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added large size elephpants #58
Conversation
Merge down
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
Will squash first ;-) |
Might be better to show the size when it is not "normal" and give all existing elephpants a size of "normal" or "small". Implementation would be a bit cleaner. |
Will you recreate a PR @wimg? |
I will, but currently reinstalling my dev system after a hardware problem. Give me a few days. |
@doppynl Re-reading your comment... isn't what you're saying contradictory ? Or am I misreading ? |
I think my comment wasn't very clear. I'll try to rephrase it. The implementation in the pull request checks the size and if it is "large" it will display the size. In other cases it will not show the size. To me the implementation would be more clean if:
This would also make it easier to make additions in the future. Like new sizes, or filtering based on size. |
Made a new pull request #86 to handle this. |
I added the large (jumbo) size elephpants. They are in the db in a field "size" (free text, who knows what we get in the future).
Fixes #7