mark elephpants as prototypes #174
Conversation
|
I think the Vegas Elephpant didn't reached the kickstarter goal, or? Will test your PR at the end of the week when everything works out. |
|
Yeah pretty much, it was done on Indiegogo which is pretty much the same thing. It only reached 27% of the target so the prototype is the only one that exists 😄 https://www.indiegogo.com/projects/phplashy-the-official-php-vegas-elephpant#/ However, on the statistics page, it's apparently in 2 herds:
I'll tidy up this branch this evening and resolve any conflicts, ready for review later this week. Thanks |
This one is real |
|
Such a shame it didn't get the funding it needed 😢 |
|
Hey @teiling88 👋 I've resolved the conflicts on this branch so it's ready whenever you are for a test :) |
|
Hey @teiling88 👋 Activity on this repo seems to have dried up a little, so I'd like to kickstart it! Have you got some time to give this PR a road test? The Kickstarter page for the Sylius Elephpant is launching soon and that's what made me remember about this PR! Thanks |
|
I just realised this branch had a merge conflict, I've sorted this now. |
JonPurvis
force-pushed
the
mark-elephpants-as-prototypes
branch
from
70ec0f5 to
9cbcebb
Compare
|
Pushed an update which removes the Prototype flag from the Sylius Elephpant as it reached its funding goal yesterday so it can go into production. |
|
Might be a bit premature since manufacturing hasn't even started |
JonPurvis
force-pushed
the
mark-elephpants-as-prototypes
branch
from
a75934e to
9cbcebb
Compare
|
Yeah I've reverted that commit, I guess the excitement of a new Elephpant got the better of me 😆 |
|
The original batch of one of the Symonfy elePHPants (I don't remember which one) was shipped from the factory to France. French customs didn't like them and disposed of them the way they do with anything else they don't want to let in the country: the incinerator. |
|
Poor Elephpants! I didn't know that happened! Thanks for the info! |
|
Hey @teiling88 👋 I'd quite like to re-visit this PR. Would you be able to have a look over it please? |
database/migrations/2023_07_29_154546_remove_prototype_elephpants_from_collections.php
Outdated
Show resolved
Hide resolved
…nts_from_collections.php Co-authored-by: Tim Bond <[email protected]>
|
Thanks @cookieguru - I forgot that Elephpant was supposedly coming, I haven't seen any info about it aside from the initial picture on Twitter |
| */ | ||
| public function up() | ||
| { | ||
| DB::statement('DELETE FROM elephpant_user WHERE elephpant_id IN (52,53,55,62,77)'); |
There was a problem hiding this comment.
| DB::statement('DELETE FROM elephpant_user WHERE elephpant_id IN (52,53,55,62,77)'); | |
| DB::statement(" | |
| DELETE | |
| FROM elephpant_user eu | |
| LEFT JOIN users u ON eu.user_id = u.id | |
| WHERE elephpant_id IN (52,53,55,62,77) | |
| AND u.twitter != 'OGProgrammer'; | |
| "); |
@OGProgrammer is active on the site and owns the prototype for 62. His herd doesn't list any other prototypes so I've kept the query simple: delete prototypes from all collections except his
| @@ -12,6 +12,9 @@ | |||
| </div> | |||
| <div class="container"> | |||
| @include('partials._search') | |||
| <p class="mb-4"> | |||
| ElePHPants marked as <strong>Prototype Only</strong> are for reference and cannot be added to your herd or traded with other users as they were never mass produced. | |||
There was a problem hiding this comment.
This disclaimer is less important than the search results so I think it should come after the results. Also, there is no need to show this text when there are no results, so this could go between the @endforeach and @else
|
Fixes #126
Following on from a discussion started by @asgrim in #126, this PR adds the ability to be able to mark Elephpants as "prototypes", which will then prevent them from being able to be added to collections and offered up for trade. This will mark the following as Prototypes:
Prototype Elephpants will only show on the following pages:
Prototype Elephpants will be excluded from:
Lastly, I've added an extra migration to remove any Prototype Elephpants from collections.