Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Disallow non-primitive values for query parameters #44

Open
franzliedke opened this issue Feb 9, 2021 · 0 comments
Open

[2.0] Disallow non-primitive values for query parameters #44

franzliedke opened this issue Feb 9, 2021 · 0 comments
Milestone

Comments

@franzliedke
Copy link
Collaborator

franzliedke commented Feb 9, 2021

Right now, we rely on Rails' to_param to pre-serialize values for use in query strings. That means, things like arrays ([1, 2]) are turned into strings separated by slashes ("1/2"). That is very arbitrary and should not be Restify's concern.

Let's disallow these cases (needs a clear definition of what cases are allowed).

This would be a subtle, but impact-ful BC break, so I would propose to target this for 2.0.

@jgraichen jgraichen added this to the 2.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants