Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Python code #74

Closed
ygoe opened this issue Apr 20, 2023 · 4 comments
Closed

Not working in Python code #74

ygoe opened this issue Apr 20, 2023 · 4 comments

Comments

@ygoe
Copy link

ygoe commented Apr 20, 2023

I'm using this extension for some time now. It works fine in .js and .php files, but shows no effect in .py files. I think it worked before, but I'm not writing Python often so I can say when.

The current version in 2.0.8 with VSCode 1.77.3 on Windows.

@alkatar21
Copy link
Collaborator

Duplicate of #69. This is the case because include and exclude were not correctly used before. This has been fixed in 2.0.8.

However, as can be seen at https://github.com/jgclark/vscode-todo-highlight#configuration, highlighting is enabled by default for only a few file types. Adding "**/*.py" to todohighlight.include should fix this for now. The setting needs to be reconsidered, as noted in #72, so that highlighting is enabled by default for most file types in the future.

@ygoe
Copy link
Author

ygoe commented Apr 20, 2023

Thank you, I can fix it now. But it's annoying to define all the file types I'm working with in the several projects. It can be a lot. Setting any type replaces the defaults, too.

@alkatar21
Copy link
Collaborator

Yes, hopefully that will be improved as soon as there is time.

@jgclark
Copy link
Owner

jgclark commented Apr 20, 2023

@ygoe Yes, this will be improved shortly. In fact I coded up #72 yesterday, and I hope over the weekend it can be tested by some others and then released.

@jgclark jgclark closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants