Dark/Light Theme mode: Define keywords color / backgroundcolor depending on day/night mode?

[schittli]

Hello

thank you for creating release 2 of this plugin and sharing your great work!

Could you please think about offering support for dark/light (or day/night) themes and allow us to define colors depending on it?
Somethin like that:

{
    "text": "### …",
    "regex": {
        // this is a 'TODO Highligt' bug: Regex for "start of line": ^ does not work, 
        // probably because it uses wrong Regex option 'multilne / single' line parsing
        "pattern": "(?<=(?:\\r\\n?|\\n)\\s*)(#{3}(:|\\s).*)(?=\\r\\n?|\\n)?"
    },

    // keep the backward compatibility
    "color": "red",
    "backgroundColor": "rgba(245, 39, 145, 0.09)",

    // The new dark/light mode
    "LightModeColor": {
      "color": "…",
      "backgroundColor": "…"
    },
    
    "DarkModeColor": {
      "color": "…",
      "backgroundColor": "…",
    }
},

Thanks a lot, kind regards,
Thomas

[jgclark]

Many thanks for your bug report and excellent suggestion. I have been thinking about the same need for different colours. Your suggested syntax seems sensible too.

[ygoe]

Is there any progress here? I just stumbled over the same problem. I've created my own colour themes for light and dark (mainly to move my settings.json customisations into a clean theme and so that I can quickly switch between light and dark theme). But the foreground colour is now fixed for one theme and hardly readable for the other. Can I include the TODO text colour in my theme or what options do I have now?

[exastone]

Chiming in here with an idea that might lead to a better one; I'd like to suggest exposing theming api specifiers so colouring can be defined by theme authors.