Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we avoid manual operation to refresh display after changing settings? #30

Open
alkatar21 opened this issue Sep 3, 2021 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@alkatar21
Copy link
Collaborator

Not too important, but when settings are changed, the previous highlights are not reseted and VSCode needs to be restarted once.

@jgclark
Copy link
Owner

jgclark commented Sep 3, 2021

Really? I find switching to a different tab and back to the one that was open is enough to re-load and re-apply the new settings. Have you tried that?

@alkatar21
Copy link
Collaborator Author

alkatar21 commented Sep 3, 2021

To be more precise, if I have 2 windows open side by side and switch between them it is not enough. If I switch tabs in one window it works.
grafik
I have changed from my configuration with the yellow font to the default, which is applied, but my configuration remains active until i switch Tabs.

This can also be a VSCode limitation? Then this can be closed.
And it's not important to me. Just wanted to note it, because it occurred to me.

@jgclark
Copy link
Owner

jgclark commented Sep 3, 2021

Yes, it's a good point. As I'm not the original author I'm not sure if this is a plugin limit, or a VSCode limit.
Another way around this might be issue the Toggle highlights command within a session.

Leaving this open in case others can advise if there's a way to get VSCode to update its view when needed.

@jgclark jgclark added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Sep 3, 2021
@alkatar21
Copy link
Collaborator Author

Toggle highlight has no effect on this. It only affects the highlights of the active configuration.

I know you're not the original author and I probably have even less knowledge of js and VSCode plugins, but I wanted to document what I noticed.

@jgclark
Copy link
Owner

jgclark commented Sep 4, 2021

Toggle highlight has no effect on this. It only affects the highlights of the active configuration.

Out of interest, are you running different workspaces in the two different windows? Or two panes inside the same workspace window?

I know you're not the original author and I probably have even less knowledge of js and VSCode plugins, but I wanted to document what I noticed.

Thanks.

@jgclark jgclark changed the title Reset after settings update. Can we avoid manual operation to refresh display after changing settings? Sep 4, 2021
@alkatar21
Copy link
Collaborator Author

Out of interest, are you running different workspaces in the two different windows? Or two panes inside the same workspace window?

Two panes inside the same workspace window.

@ygoe
Copy link

ygoe commented Jul 3, 2022

If this issue is about the background colours repainted over already painted backgrounds when settings are changed, then this also applies when starting VSCode. I found an already open document with very intense highlights. Opening another document and closing it again fixed the appearance (like switching tabs does if you already have another tab open). My TODO background colour is #ff200040 so it has transparency, and painting it multiple times sums up each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants