From 9f996f881c806c4cbbb4487fa2cff9777d41fb8c Mon Sep 17 00:00:00 2001
From: Tien Dat Nguyen <ntd.bk.k56@gmail.com>
Date: Mon, 15 Apr 2024 01:45:01 +0200
Subject: [PATCH] Remove old annotations when regenerating tabs

- Tabs were added every time the plugin was run, resulting in duplicates.
- In cases where the note changes, the glyphs were simply overlaid on one another,
making the result incorrect.
- Fix: while adding annotations, check the segment for those
which have the same offset as the new annotation, and remove them.
---
 tin_whistle_tablature.qml | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tin_whistle_tablature.qml b/tin_whistle_tablature.qml
index 52c8b8a..a394ac5 100644
--- a/tin_whistle_tablature.qml
+++ b/tin_whistle_tablature.qml
@@ -103,6 +103,26 @@ MuseScore {
       console.log("^^ -------- " + title + " ---------- ^^")
    } // end dumpObjectEntries
 
+   function removeDuplicatesInSegment(segment, elementToKeep) {
+      var removables = [];
+
+      for (var i = 0; i < segment.annotations.length; i++) {
+         var element = segment.annotations[i];
+         if (element.is(elementToKeep)) {
+            continue;
+         }
+
+         if (element.offsetX == elementToKeep.offsetX && element.offsetY == elementToKeep.offsetY) {
+            removables.push(element);
+         }
+      }
+
+      for (var i = 0; i < removables.length; i++) {
+         var element = segment.annotations[i];
+         removeElement(element);
+      }
+   }
+
    function renderTinWhistleTablature () {
       curScore.startCmd();
 
@@ -288,6 +308,8 @@ MuseScore {
                      // (See the note below about behavior of the text.offsetY property.)
                      text.offsetY = tabOffsetY   // place the tab below the staff
 
+                     removeDuplicatesInSegment(cursor.segment, text);
+
                      // Create new text element for next tab placement
                      text = newElement(Element.STAFF_TEXT)
                   }
@@ -340,6 +362,8 @@ MuseScore {
                      else
                         text.offsetX = 0.5
 
+                     removeDuplicatesInSegment(cursor.segment, text);
+
                      // Create new text element for next tab placement
                      text = newElement(Element.STAFF_TEXT)
                   } // end if repeated
@@ -376,6 +400,8 @@ MuseScore {
                      // (See the note below about behavior of the text.offsetY property.)
                      text.offsetY = tabOffsetY   // place the tab below the staff
 
+                     removeDuplicatesInSegment(cursor.segment, text);
+
                      // Create new text element for next tab placement
                      text = newElement(Element.STAFF_TEXT)
                   }