Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password String Length Error #959

Closed
5 tasks
tdgeery opened this issue May 8, 2024 · 7 comments · Fixed by #962 or #1024
Closed
5 tasks

Password String Length Error #959

tdgeery opened this issue May 8, 2024 · 7 comments · Fixed by #962 or #1024
Assignees
Labels
bug Something isn't working

Comments

@tdgeery
Copy link

tdgeery commented May 8, 2024

Describe the bug

With new releases of provider we're getting errors for artifactory_managed_user:

╷
│ Error: Invalid Attribute Value Length
│
│   with artifactory_managed_user....,
│   on users.tf line 60, in resource "artifactory_managed_user" "<redacted>":
│   60:   password = random_password.<redacted>.result
│
│ Attribute password string length must be at least 12, got: 10
╵

Previously in 10.3.3 we didn't see this error.

Requirements for and issue

  • A description of the bug
  • A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
  • Your version of artifactory (you can curl it at $host/artifactory/api/system/version
  • Your version of terraform
  • Your version of terraform provider

Expected behavior

I understand this is likely a security concern, however we're not looking to update our password at this time.. There needs to be a way to allow this password to exist in its current non-conforming state.

Additional context
Add any other context about the problem here.

@tdgeery tdgeery added the bug Something isn't working label May 8, 2024
@alexhung
Copy link
Member

alexhung commented May 8, 2024

@tdgeery Thanks for the report! I don't recall the reason the min length of 12 was chosen before. Checking both the cloud version and self-hosted version, it looks like the default min length is 8 characters. Obviously for self-hosted, customers are free to change this default length.

I'll update the resource validation to 8 characters min so existing passwords should pass.

alexhung added a commit that referenced this issue May 10, 2024
@tdgeery
Copy link
Author

tdgeery commented Jun 28, 2024

Is it possible to configure this length? or option to remove this check? I am blocked upgrading provider since we have some users with passwords of 7 character length...

@alexhung
Copy link
Member

@tdgeery Not currently for either configurable or removal of the check. I'll add this to our plan to support these.

@tdgeery
Copy link
Author

tdgeery commented Jun 28, 2024

That would be great, wouldn't to stay too far from latest 😛

@alexhung
Copy link
Member

@tdgeery Ideally your users should update their passwords to longer length 😄 but I totally understand the challenge that involves.

@tdgeery
Copy link
Author

tdgeery commented Jun 28, 2024

Wish that was actually achievable 😆

@alexhung
Copy link
Member

@tdgeery #1024 should allow you to configure the resource password validation to match your Artifactory settings.

alexhung added a commit that referenced this issue Jul 16, 2024
Add 'password_policy' attribute to allow configurable validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants