Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Xray APIs should not use ArtifactoryClientBuilder #224

Closed
eyalbe4 opened this issue Nov 6, 2020 · 1 comment
Closed

The Xray APIs should not use ArtifactoryClientBuilder #224

eyalbe4 opened this issue Nov 6, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 6, 2020

Describe the bug
Following the merge of #211 we should refactor the code, so that the new Xray APIs introduced in this PR do not use the ArtifactoryClientBuilder. We should either create a generic builder for all JFrog services, or alternatively create client APIs for Xray.
See the following comment as part of the above PR:

Now that ArtifactoryClientBuilder also needs to be used for Xray, we should rename it to HttpClientBuilder.
We should also move the httpclient package, which is currently located under the artifactory directory, to be one level up, next to the artifactory dir.
rthttpclient should be renamed to httpclient, or if the the httpclient is already taken as an alias in the file, maybe jfroghttpclient.

To Reproduce
N/A

Expected behavior
N/A

Screenshots
N/A

Versions

  • JFrog Go client version: N/A
  • JFrog Go client operating system: N/A
  • Artifactory version: N/A
@eyalbe4 eyalbe4 added the bug Something isn't working label Nov 6, 2020
@eyalbe4
Copy link
Contributor Author

eyalbe4 commented Jan 24, 2021

#255 resolves this issue.

@eyalbe4 eyalbe4 closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant