Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the support bundle upload plugin #144

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

YonatanHen
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

CLA Assistant Lite bot All Contributors have accepted the Developer Terms.

@YonatanHen
Copy link
Contributor Author

I have read the Developer Terms and I hereby accept the terms

@eyalbe4 eyalbe4 merged commit ab9be48 into jfrog:master Oct 19, 2023
1 check passed
@eyalbe4
Copy link
Contributor

eyalbe4 commented Oct 19, 2023

@YonatanHen -
The plugin is published, but there’s an issue with it -

  1. It can be installed using the following command - jf plugin install upload-support-bundle . You README documentation however says otherwise.
  2. The plugin name is - support-bundle as you can see in the CLI embedded help as you can see below, while when installing it, you use the name - upload-support-bundle

Go ahead and align all the above. If a new version needs to be released for this alignment, open a new PR.
Once all is alugned, we’ll add the plugin in the registry’s README.

@YonatanHen
Copy link
Contributor Author

Hi, @eyalbe4 thanks for the feedback, I have opened PR #145, including the changes you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants