Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildinfo.TimeFormat rejects valid ISO8601 timestamps #292

Open
Ext3h opened this issue Jan 8, 2025 · 1 comment
Open

buildinfo.TimeFormat rejects valid ISO8601 timestamps #292

Ext3h opened this issue Jan 8, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Ext3h
Copy link

Ext3h commented Jan 8, 2025

Describe the bug

buildinfo.TimeFormat does not match 2025-01-08T14:37:22.000Z because -0700 was used in the layout string instead of Z0700.

This is the root cause of jfrog/jfrog-cli#2823

In comparison, Artifactory does accept any valid ISO8601 conforming timestamp in the build info.

Current behavior

buildinfo.TimeFormat does not match 2025-01-08T14:37:22.000Z.

Reproduction steps

See jfrog/jfrog-cli#2823

Expected behavior

buildinfo.TimeFormat does match 2025-01-08T14:37:22.000Z.

Operating system type and version

JFrog CLI 2.73.0

@Ext3h Ext3h added the bug Something isn't working label Jan 8, 2025
@Ext3h
Copy link
Author

Ext3h commented Jan 8, 2025

Just for completeness sake - this has already prompted a workaround in Conan 2.x: https://github.com/conan-io/conan-extensions/blob/main/extensions/commands/art/cmd_build_info.py#L59

But the fact remains that the JF CLI tool is currently incompatible with valid build specs.

And the published schema also includes Z as a valid time zone designator:

"pattern": "^\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}.\\d{3}(Z|[+-]\\d{4})$"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant