Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to migrate from legacy compliance mode #12806

Open
dudaerich opened this issue Feb 19, 2025 · 3 comments · May be fixed by #12807
Open

How to migrate from legacy compliance mode #12806

dudaerich opened this issue Feb 19, 2025 · 3 comments · May be fixed by #12807
Assignees
@joakime
Labels
Question

Comments

@dudaerich
Copy link

Jetty Version
12.0.9

Jetty Environment
ee8

Java Version
21

Question

Hi community, I would like to ask question about Jetty compliance mode. We are in a situation that we use legacy compliance mode for URIs and Cookies as it was easier for us to be backward compatible when we moved our application into Jetty. We are trying to figure out how to move on from this state.

In the first step, we would like to identify requests with violations and only log them so we can investigate origin of the requests and fix it. ComplianceViolation.Listener seems to be a great fit for this use case, but it catches only violations not present in compliance mode. So we cannot be backward compatible and in the same time log the violations.

It would help us if the ComplianceViolation.Listener was invoked even if the violation is present in the compliance mode. What do you think?
@joakime
Copy link
Contributor

joakime commented Feb 19, 2025

I would think that while you are in legacy modes, use the ComplianceViolation.Listener and capture where things are triggering the violations.

Make note of those violations and then work on producing the requests in a way that those violations do not trigger anymore.
Once you reach that point, it's safe to turn off the legacy modes and go back to standard.

@dudaerich
Copy link
Author

dudaerich commented Feb 19, 2025 •
edited
Loading

The problem is that while we are in legacy modes, the ComplianceViolation.Listener is not invoked - see https://github.com/jetty/jetty.project/blob/61f773643ee366a52097d02a486696496560f820/jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java#L429C1-L452C6

The listener is invoked only if !compliance.allows(violation).

@joakime
Copy link
Contributor

joakime commented Feb 19, 2025

The listener is invoked only if !compliance.allows(violation).

Yeah, that's a bug.
Fixing it now.

joakime added a commit that referenced this issue Feb 19, 2025
@joakime
Issue #12806 - UriCompliance listener reporting updates
9371948
@joakime joakime linked a pull request Feb 19, 2025 that will close this issue
Open
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.18 Feb 21, 2025
@joakime joakime self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Question
Projects
Jetty 12.0.18
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #12806 - UriCompliance listener reporting updates jetty/jetty.project
2 participants
@joakime @dudaerich