Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Cassandra nodetool tests fail to compile with Go 1.8.x #300

Closed
wallrj opened this issue Mar 22, 2018 · 1 comment
Closed

Cassandra nodetool tests fail to compile with Go 1.8.x #300

wallrj opened this issue Mar 22, 2018 · 1 comment
Assignees
Labels

Comments

@wallrj
Copy link
Member

wallrj commented Mar 22, 2018

richard@pet-instance-1:~/go/src/github.com/jetstack/navigator$ go test ./pkg/cassandra/nodetool/...
# github.com/jetstack/navigator/pkg/cassandra/nodetool_test
pkg/cassandra/nodetool/nodetool_test.go:336: ts.Client undefined (type *httptest.Server has no field or method Client)
FAIL    github.com/jetstack/navigator/pkg/cassandra/nodetool [build failed]
?       github.com/jetstack/navigator/pkg/cassandra/nodetool/client     [no test files]
?       github.com/jetstack/navigator/pkg/cassandra/nodetool/fake       [no test files]
richard@pet-instance-1:~/go/src/github.com/jetstack/navigator$ go version
go version go1.8.3 linux/amd64

Not sure if we need to fix this.
Perhaps we should just document that we only support Navigator compiled with Go 1.9+

/kind bug

Noticed this while running make test from #242

@munnerz
Copy link
Contributor

munnerz commented Mar 27, 2018

I'm happy to accept that you need Go 1.9+ to build, otherwise we're locking ourselves out of new features in the stdlib to support old and unused (by us) Go versions.

This is also only in tests, and it'd still be possible to build navigator itself with 1.8 anyway.

/close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants