Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEventData.EventId #35

Closed
bartelink opened this issue Feb 17, 2020 · 0 comments
Closed

Add IEventData.EventId #35

bartelink opened this issue Feb 17, 2020 · 0 comments
Milestone
2.0

Comments

@bartelink
Copy link
Collaborator

bartelink commented Feb 17, 2020 •
edited
Loading

In order to support roundtripping the EventId used to identify and/or deduplicate events in EventStore, SqlStreamStore and more:

  • IEventData should expose it (as a Guid)
  • TimelineEvent ctor should all-but require one (default to Guid.Empty if nothing relevant available on a given store)
  • EventData ctor should default it to Guid.NewGuid()
@bartelink bartelink added this to the 2.0 milestone Feb 17, 2020
bartelink added a commit that referenced this issue Feb 19, 2020
@bartelink
Add EventId to IEventData re #35 (#36)
6a6122d
@bartelink bartelink mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@bartelink