Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 1.0.0 checklist #18

Closed
4 tasks done
bartelink opened this issue Sep 11, 2019 · 1 comment
Closed
4 tasks done

V 1.0.0 checklist #18

bartelink opened this issue Sep 11, 2019 · 1 comment

Comments

@bartelink
Copy link
Collaborator

bartelink commented Sep 11, 2019 •
edited
Loading

There's no real blocker for a non-RC release, but given the central role the IEvent and IIndexedEvent interfaces occupy in Equinox, Propulsion and apps based thereon, it really is the last chance to do a breaking change for the foreseeable. This is the complete list of ideas - how many actually get actioned is up for debate

  • Consider renaming IEvent to something that doesn't clash with / shadow FSharp.Control.IEvent
  • make IndexedEventData.new align with EventData.Create
  • consider hiding EventData record and/or its equality or comparison facilities
  • consider having IUnionEncoder.Encode accept a Context in order that a single Codec instance can contextually enrich events with correlationId and causationId values
This was referenced Sep 21, 2019
Merged
Merged
Closed
@bartelink
Copy link
Collaborator Author

All resolved+merged; release imminent

@bartelink bartelink mentioned this issue Sep 25, 2019
Closed
@bartelink bartelink reopened this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink