Skip to content

"Danger" bot doesn't need to ask for strict mode for ES Modules #2708

Closed
@quantizor

Description

@quantizor

The relevant code in dangerfile:

// Ensure the use of 'use strict'; on all files
const noStrictFiles = newJsFiles.filter(filepath => {
  const content = fs.readFileSync(filepath).toString();
  return !includes(content, 'use strict');
});

Basically ES modules are strict mode by default, so the check should look for use of "import"/"export" to determine if flagging is required.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions