-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing cliOptions through normal jest config? #66
Comments
See #58, #31, #10, but also jestjs/jest#4278 (comment) |
Hey, thanks! :) Uh, that's both very sad and surprising... I've just seen that runners accept Any suggestion where this can be started? I'm not familiar with the jest codebase. |
Actually, there is a way. Hacky one of course. But for now, we can use it until it land official. And of course, we will see the validation warnings but they don't break the execution anyway.
Why in |
This is the smallest and only needed change which adds such support. https://github.com/tunnckoCoreHQ/devest/commit/508688f2b8157bbc74b3415930b2a97bfeeb1db0 Want PR? |
I don't think adding a bunch of validation warnings, or relying on a hack, is worth it. |
It's optional anyway and allows you to build on top of Jest, and when you know what are you doing. It worths when you know what are you doing and why. Also, it's not "a bunch", it's one warning. And all this is some temporary solution. |
How is one supposed to pass
Is there some another way? |
EDIT: I think I got it to work -- configuration done in package.json helped and also installing fresh node_modules hey @raine 👋 did u ever figure out how I might be misunderstanding the README -- and havent had much luck with |
Would you consider this or not? Currently, we require to have
jest-runner-eslint
config file (or field) which... isn't that good if you want to provide "zero config" experience, or near zero.So here we'll have
config.cliOptions || explorer.searchSync(config.rootDir);
Worth nothing.
I'll PR if you agree.
The text was updated successfully, but these errors were encountered: