Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to temporarily hide "custom patch" panel #910

Open
OliverJAsh opened this issue Jul 21, 2020 · 3 comments
Open

Provide a way to temporarily hide "custom patch" panel #910

OliverJAsh opened this issue Jul 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@OliverJAsh
Copy link

Is your feature request related to a problem? Please describe.
When I am selecting lines/chunks to add to a patch, I have this problem where it is difficult to see the full code I am selecting because the "custom patch" panel is taking up too much space. For example, here I have a chunk selected, but I have to scroll to see the full chunk:

image

Describe the solution you'd like
I would prefer a workflow where I'm focused on selecting lines/chunks and then, when I'm done, switching to another view which just shows the custom patch. This is similar to what I would do outside of lazygit—I would run git add --patch and then, when I'm done, run git diff --cached to review the staged patch before committing. If I need to make more changes I can jump back to git add --patch.

Describe alternatives you've considered

Additional context
#749 would also help with this

@OliverJAsh OliverJAsh added the enhancement New feature or request label Jul 21, 2020
@jesseduffield
Copy link
Owner

You can get halfway there by tapping '+' until the currently focused panel takes up the whole screen, however at the moment it's not possible to focus the secondary panel. I'll need to add support for that

@veremenko-y
Copy link
Contributor

I would love this as well. I generally want to preview changes before doing selection to stage, and I have to press + twice until the 3rd view, then same + twice to get out of it.

@veremenko-y
Copy link
Contributor

As an alternative, what about hiding "Staged changes" and "Custom patch" windows until there's something selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants