Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3 & hex.pm #44

Open
jtmoulia opened this issue Sep 14, 2015 · 11 comments
Open

rebar3 & hex.pm #44

jtmoulia opened this issue Sep 14, 2015 · 11 comments

Comments

@jtmoulia
Copy link

Hello --

rebar3 will be using hex.pm as its package manager. To simplify dep management for packages which depend on this library, it'd be great if websocket_client was migrated to rebar3 and published on hex.

Currently rebar3 is at beta-2, so it would make sense to migrate to rebar3 in a branch off master, and then merge back in once rebar3 hits a stable release. In the meantime, websocket_client could be published to hex. Example from a fork: sanmiguel@bfc6b87

I'd be happy to work on this, but I first want to check if people are interested.

@ypaq
Copy link
Contributor

ypaq commented Sep 14, 2015

👍

@jeremyong
Copy link
Owner

If you supply a commit, I can create a branch for it!

@ypaq
Copy link
Contributor

ypaq commented Sep 14, 2015

I think it would be advantageous to make it work with both forks and merge @sanmiguel's changes, e.g., create a hex package for @jeremyong's version (0.7.x) and for @sanmiguel's (1.1.x). There are severe issues with v0.7 but I understand there are behavior changes that come with 1.1.x. I have stopped using v0.7 and recommend to update to 1.1.x.

@sanmiguel
Copy link

I'd be happy to publish my fork to hex.pm (I actually tried this before, and it appears that I've left a residual presence unintentionally). It already supports rebar3 and has some fairly significant changes for stability and resilience. However, the behaviour interface has also been modified and extended and it's far less lightweight than the original fork (it's now backed by gen_fsm).

I wonder if at this point I should just rename mine, allowing both to coexist. @jeremyong do you have any thoughts on this?

@jeremyong
Copy link
Owner

I'm actually happy to point to someone else's fork if it is being more actively maintained and/or fixes issues with my current fork.

@sanmiguel
Copy link

I am and have been actively maintaining and semi-regularly extending my fork for a year or so now. I've also got more plans for future work (some of which are captured as enhancement issues).

I'd happily take up maintaining the hex package as well.

@sanmiguel
Copy link

I'm ready to publish my fork to hex.pm, @jeremyong you sure you're happy for me to do that?

@jeremyong
Copy link
Owner

Go for it

@ypaq
Copy link
Contributor

ypaq commented Sep 15, 2015

👍

@sanmiguel
Copy link

@jtmoulia
Copy link
Author

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants