Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image from the signature doesn't show on receivers end when I reply to email #162

Open
AbeEtan opened this issue Jan 25, 2023 · 8 comments

Comments

@AbeEtan
Copy link

AbeEtan commented Jan 25, 2023

(package-install 'org-msg)
 (setq mail-user-agent 'mu4e-user-agent)
 (require 'org-msg)
 (setq org-msg-options "html-postamble:nil H:5 num:nil ^:{} toc:nil author:nil email:nil \\n:t"
	org-msg-startup "hidestars indent inlineimages"
	org-msg-greeting-fmt "\nHi%s,\n\n"
	org-msg-greeting-name-limit 3
	org-msg-default-alternatives '((new		. (text html))
				       (reply-to-html	. (text html))
				       (reply-to-text	. (text)))
	org-msg-convert-citation t
	org-msg-signature (file-string "~/onedrive/RoamNotes/mu4e signatures/orgmsgsignature.org"))
(org-msg-mode)

I also tried adding the signature as a greeting.
org-msg-greeting-fmt (file-string "~/onedrive/RoamNotes/mu4e signatures/orgmsgsignature.org")

The issue of the image not showing still persists. Please advise.

@gajama
Copy link
Contributor

gajama commented Jan 27, 2023

Does the image show if you preview the message?

@AbeEtan
Copy link
Author

AbeEtan commented Jan 27, 2023

Unfortunately, it doesn't. When I type "R" and reply to a message, the signature doesn't load in org-msg mode. Please advise.

@gajama
Copy link
Contributor

gajama commented Jan 27, 2023

If you export orgmsgsignature.org as HTML through the normal Org export commands, is the image included in the export?

@AbeEtan
Copy link
Author

AbeEtan commented Jan 27, 2023

If you export orgmsgsignature.org as HTML through the normal Org export commands, is the image included in the export?

Yes, of course.

In addition, When I compose an email, the image shows up and everything, however, the problem happens when I reply to the email and want to send an email using org-msg, it doesn't work.

@AbeEtan
Copy link
Author

AbeEtan commented Jan 27, 2023

At this point, I can confidently say that org-msg doesn't work when I reply to an email. It only works when I compose a new email/message.

If you allow me, can I rephrase my issue to "Org-msg not activated for mu4e-compose-reply".

This #153 seems to be my issue.

#153 (comment)

@gajama
Copy link
Contributor

gajama commented Jan 28, 2023

Well, the PR I put in to fix #157, which should fix #153 also, was merged yesterday, so you might want to try updating to the latest commit and see if it fixes your issue.

@gajama
Copy link
Contributor

gajama commented Jan 28, 2023

It works for my signature file. Mine is just some HTML wrapped in Org #+begin_export html end_export tags, and the images are links rather than inlined, but the HTML is included correctly.

@AbeEtan
Copy link
Author

AbeEtan commented Jan 28, 2023

Amazing, it's working now for me. Apparently as you mentioned the recent updated fixed it. Thank you so much. You guys are the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants