Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jepsen seems to have given the wrong answer. #596

Open
shihuili1218 opened this issue Sep 27, 2024 · 4 comments
Open

Jepsen seems to have given the wrong answer. #596

shihuili1218 opened this issue Sep 27, 2024 · 4 comments

Comments

@shihuili1218
Copy link

hi jepsen team.

I think the part in the red box satisfies linear consistency, but Jepsen seems to have given the wrong answer.

screenshot-20240927-160816
screenshot-20240927-161403

Jepsen's answer seems to overlook the Wirte 638 operation of node 1

@shihuili1218
Copy link
Author

shihuili1218 commented Sep 27, 2024

@aphyr

[org.clojure/clojure "1.9.0"]
[jepsen "0.1.11"]

Looking forward to your reply. If you need any further information, I am more than happy to provide it

@aphyr
Copy link
Collaborator

aphyr commented Sep 27, 2024 via email

@shihuili1218
Copy link
Author

shihuili1218 commented Sep 28, 2024

write 638 of node 1 has just timed out, it may have succeeded or failed. I think Jepsen should include it in the criteria for linear consistency.

Perhaps I didn't tell Jepsen that this was a timeout request? This is my code, how should I modify it?

(defrecord Client [conn]
  client/Client
  (open! [this test node]
    (-> this
        (assoc :conn (create-client node))))
  (setup! [this test])
  (invoke! [this test op]
    (try
      (case (:f op)
            :read  (assoc op :type :ok, :value (read this))
            :write (do
                     (write this (:value op))
                     (assoc op :type :ok)))
      (catch Exception e
        (let [^String msg (.getMessage e)]
          (cond
           (and msg (.contains msg "UNKNOWN")) (assoc op :type :fail, :error :timeout)
           :else
           (assoc op :type :fail :error (.getMessage e)))))))

  (teardown! [this test])

  (close! [_ test]))

@aphyr
Copy link
Collaborator

aphyr commented Sep 28, 2024

See https://github.com/jepsen-io/history; you want to record indeterminate failures as type :info, not :fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants