Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 7.0 incompatibilities #48

Closed
Garanaw opened this issue Mar 4, 2020 · 2 comments
Closed

Laravel 7.0 incompatibilities #48

Garanaw opened this issue Mar 4, 2020 · 2 comments

Comments

@Garanaw
Copy link

Garanaw commented Mar 4, 2020

The last released Laravel has updated his internal dependencies based on Symfony to the 5.* series, including the console.

As for this library, it still requires the 3.0 && 4.0 series, preventing to upgrade the framework.

For what I could see in the library, the only exception is the InvalidPrimeException, which extends from RangeException, which extends from RuntimeException, which extends from Exception, which at last implements the Throwable interface. Being that the only requirement (AFAIK), this can be satisfiable by just adding |^5.0 to the composer.json file under the symfony/console dependency.

Happy to PR it if you're busy

@jenssegers
Copy link
Owner

A PR would be lovely!

@jenssegers
Copy link
Owner

Should be fixed with #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants