Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated mobiledetect/mobiledetectlib (2.7) #207

Open
JmRy opened this issue Nov 2, 2023 · 5 comments
Open

outdated mobiledetect/mobiledetectlib (2.7) #207

JmRy opened this issue Nov 2, 2023 · 5 comments

Comments

@JmRy
Copy link

JmRy commented Nov 2, 2023

Hello,

Your library uses an outdated version of mobiledetect/mobiledetectlib (2.7). The latest release of this library does not detect the newest desktop versions of Firefox, Edge, ... It returns true on the isMobile function.

It would be nice to update your library with the 4.8 version of mobiledetect/mobiledetectlib.

Thank you in advance. ;-)

@Misagh90
Copy link

Misagh90 commented Nov 7, 2023

I tried composer update & it's not working from 2.8.41 to upper versions

serbanghita added a commit to serbanghita/Mobile-Detect that referenced this issue Nov 7, 2023
…36/files

Fixes: jenssegers/agent#207

The getMobileDetectionRules() should always be owned by Mobile_Detect.php class.
@serbanghita
Copy link

Mobile Detect 2.8.45

fixes two things:

  1. added back tests folder which was mandatory for jenssegers/agent tests to work.
  2. reverted back from static to self to prevent override of "mobile" specific rules.

jenssegers/agent should work now

@mhdhamouday
Copy link

@serbanghita, could you kindly upload this version to the packagelist so that we can update it via Composer?

@serbanghita
Copy link

@mhdhamouday It should already be in there https://packagist.org/packages/mobiledetect/mobiledetectlib#2.8.45
When I publish a tag it automatically gets published in packagist, let me know if there are any issues

@mhdhamouday
Copy link

@serbanghita I apologize if my question is unclear, but I'm referring to updating the dependency on "mobiledetect" to the latest version, like "4.8.042023". Your package is currently using an outdated version of the "mobiledetect" package, specifically version "2.8".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@JmRy @serbanghita @Misagh90 @mhdhamouday and others