Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The request of a dependency is an expression with React #150

Open
nobobo1234 opened this issue Aug 31, 2021 · 2 comments
Open

The request of a dependency is an expression with React #150

nobobo1234 opened this issue Aug 31, 2021 · 2 comments

Comments

@nobobo1234
Copy link

Hello there,

When I'm adding this project to React and importing it with es6 imports I get the following warning in my log:

./node_modules/node-ical/ical.js
Critical Dependency: the request of a dependency is an expression

Now I suppose this is because of the dynamic import on line 107 of ical.js. Any way to fix this?

@LunaSquee
Copy link

LunaSquee commented Oct 5, 2021

I'm not sure why they opted to require that inside a function but in theory you could move the require to the top with the other ones. Move require('path') also in that case.

@simonedelmann
Copy link

Is there any progress on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants