From 1aed85f4488b079f3bd7223153c8a39df7bfd06f Mon Sep 17 00:00:00 2001 From: Thorsten Scherler Date: Thu, 19 Sep 2024 17:32:38 +0200 Subject: [PATCH] [JENKINS-73744_follow_up] add npm lock to ignore Signed-off-by: Thorsten Scherler --- .github/renovate.json | 2 +- .gitignore | 3 +++ CONTRIBUTING.md | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/renovate.json b/.github/renovate.json index 1de5552206ed..90c5a18d9f6d 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -128,7 +128,7 @@ { "customType": "regex", "fileMatch": [ - "war/pom.xml" + "pom.xml" ], "matchStrings": [ "(?.*?)" diff --git a/.gitignore b/.gitignore index c09d79fcf8c4..55e1eebe8e09 100644 --- a/.gitignore +++ b/.gitignore @@ -79,3 +79,6 @@ node_modules/ # Generated JavaScript Bundles jsbundles + +# jenkins generated npm lock files at build time, however that should not be checked in ever +package-lock.json \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d2f4700a3ab7..ab76ec3d0fba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -52,6 +52,8 @@ MAVEN_OPTS='--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/ja ### Running the Yarn frontend build +**NOTE** If you are already use a system that has yarn installed globally, you do not need to change your path. + To run the Yarn frontend build, after [building the WAR file](#building-the-war-file), add the downloaded versions of Node and Yarn to your path: ```sh