diff --git a/docker-bake.hcl b/docker-bake.hcl index caec0cb6..98b94e18 100644 --- a/docker-bake.hcl +++ b/docker-bake.hcl @@ -141,15 +141,6 @@ function "toolsversion" { : version) } -# Return the Windows version digest to use for windowsservercore ltsc2019 image -# TODO: workaround, to be removed when https://github.com/microsoft/Windows-Containers/issues/493 is resolved -function "windowsversiondigest" { - params = [version] - result = (equal("ltsc2019", version) - ? "@sha256:6fdf140282a2f809dae9b13fe441635867f0a27c33a438771673b8da8f3348a4" - : "") -} - target "alpine" { matrix = { jdk = jdks_to_build @@ -217,9 +208,7 @@ target "nanoserver" { JAVA_HOME = "C:/openjdk-${jdk}" JAVA_VERSION = "${replace(javaversion(jdk), "_", "+")}" TOOLS_WINDOWS_VERSION = "${toolsversion(windows_version)}" - # TODO: workaround, to be removed when https://github.com/microsoft/Windows-Containers/issues/493 is resolved - WINDOWS_VERSION_DIGEST = windowsversiondigest(windows_version) - WINDOWS_VERSION_TAG = windows_version + WINDOWS_VERSION_TAG = windows_version } tags = [ # If there is a tag, add versioned tag suffixed by the jdk @@ -244,9 +233,7 @@ target "windowsservercore" { JAVA_HOME = "C:/openjdk-${jdk}" JAVA_VERSION = "${replace(javaversion(jdk), "_", "+")}" TOOLS_WINDOWS_VERSION = "${toolsversion(windows_version)}" - # TODO: workaround, to be removed when https://github.com/microsoft/Windows-Containers/issues/493 is resolved - WINDOWS_VERSION_DIGEST = windowsversiondigest(windows_version) - WINDOWS_VERSION_TAG = windows_version + WINDOWS_VERSION_TAG = windows_version } tags = [ # If there is a tag, add versioned tag suffixed by the jdk diff --git a/windows/nanoserver/Dockerfile b/windows/nanoserver/Dockerfile index 67703ba1..a37a5e3f 100644 --- a/windows/nanoserver/Dockerfile +++ b/windows/nanoserver/Dockerfile @@ -24,9 +24,7 @@ ARG WINDOWS_VERSION_TAG ARG TOOLS_WINDOWS_VERSION -# TODO: workaround, to be removed when https://github.com/microsoft/Windows-Containers/issues/493 is resolved -ARG WINDOWS_VERSION_DIGEST # Empty by default -FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}${WINDOWS_VERSION_DIGEST}" AS jdk-core +FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}" AS jdk-core # $ProgressPreference: https://github.com/PowerShell/PowerShell/issues/2138#issuecomment-251261324 SHELL ["powershell.exe", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] diff --git a/windows/windowsservercore/Dockerfile b/windows/windowsservercore/Dockerfile index 929a3695..aec1769c 100644 --- a/windows/windowsservercore/Dockerfile +++ b/windows/windowsservercore/Dockerfile @@ -24,9 +24,7 @@ ARG WINDOWS_VERSION_TAG ARG TOOLS_WINDOWS_VERSION -# TODO: workaround, to be removed when https://github.com/microsoft/Windows-Containers/issues/493 is resolved -ARG WINDOWS_VERSION_DIGEST # Empty by default -FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}${WINDOWS_VERSION_DIGEST}" AS jdk-core +FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}" AS jdk-core # $ProgressPreference: https://github.com/PowerShell/PowerShell/issues/2138#issuecomment-251261324 SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] @@ -40,7 +38,7 @@ RUN New-Item -ItemType Directory -Path C:\temp | Out-Null ; ` $proc.WaitForExit() ; ` Remove-Item -Path C:\temp -Recurse | Out-Null -FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}${WINDOWS_VERSION_DIGEST}" +FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}" ARG JAVA_HOME ENV JAVA_HOME=${JAVA_HOME}