-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Episode metadata missing #6
Comments
I have the same problem |
I gave it a try myself and got the metadata refresh working. I still have to figure out how the GetSearchResults() is used before I can submit a PR. By default it takes the anime-ID from the series and the episode number from where jellyfin guesses it. You can override both of them on each episode, for example for specials or to work around other issues. It's not user-friendly though. TODO list:
Usage for a pure AniDB setup:
Did I miss anything? Are there any other known bugs/limitations? |
I'm glad that someone's working on this - I haven't had the time to take a look at this myself due to work and other ongoing commitments. For anyone who has this issue and wants to fix it (at least for the time being), I've personally been using Plex as a "backend" to fetch the metadata, and Jellyfin as the frontend. Specifically, I use the HAMA agent to fetch the metadata, and then use the Lambda agent to export this metadata to .nfo files, which Jellyfin reads and prioritizes over other metadata sources. With a little bit of scripting, there shouldn't be too much of a delay between Plex picking up the series and Jellyfin displaying it. It definitely isn't ideal, and the reason I moved to Jellyfin was to reduce my dependence on closed source applications where possible, but Jellyfin is still growing, and I'm sure that it'll only keep improving. |
Unfortunately I ran into some sort of wall regarding season/episode numbering (especially specials) and usability in general. I tried to get it working properly on a small subset of just 3 series, but it is simply impossible to get what I want on all of them simultaneously without renaming/moving most of the files and overriding the provider IDs on most of them too (and even then, not sure how reliable and reproducible it is). I am definitely not going to do that on my whole collection. At the moment, I am trying to build a tool+plugin to produce the required directory structure and insert at least the provider IDs into the metadata so the existing plugins can do their job. But at that point it is probably easier to let my tool handle everything rather than getting multiple plugins to cooperate. A pure jellyfin solution would probably require a rewrite of the series stuff to remove all guessing and to make it more flexible in general. And also a completely new UI for an efficient manual classification of all new files (because there is no guessing anymore). The current logic seems to work fine for mainstream series, so it should probably be a dedicated anime category and that is blocked by the db rewrite as far as I understand. |
Having a pure Jellyfin solution would be ideal, especially if we could replicate what HAMA does - in my experience, HAMA does a great job of guessing, matching and fetching when paired with AniDB as a provider. You've mentioned season/episode numbering - do you use TheTVDB as your provider? From my understanding, TheTVDB actually works better with Jellyfin. You might want to take a look at this custom plugin that might work for your use case - https://github.com/nielsvanvelzen/jellyfin-plugin-resolver. While the author refers to it as "a hack" as it overrides other resolvers, it might be worth a shot. |
In the best case we'd always have a way to force a specific episode/special by supplying not only an anidb id, but also a uid for a specific episode/special. Other than that, anidb in general is just the best and most complete source to tap into, it should be the baseline I think. On top of things, this will be HIGHLY relevant: jellyfin/jellyfin#5732 |
I do understand the appeal of that for the odd special, but to implementing something that niche might be far-fetched if it isn't going to be used too often. As indicated in the issue above, this seems to be a non-priority for most of the developers. Sadly, I am in no position to work on this myself, and have resorted to my workaround of basically disregarding Jellyfin's metadata fetching capabilities and relying on HAMA instead. I am going to digress on a brief tangent - something that shouldn't be in this issue, but simply is because I don't have a better place to express this. If you have the resources and willingness to setup a local Plex instance (which doesn't need an account) that merely fetches the metadata and exports those as .nfo files, I would recommend that as a stopgap until someone who's both capable and interested in working on streamlining the anime experience for "us weebs". I say this as having used the official AniDB plugin by itself, using it along with other anime sources, using the custom resolver linked above and even flirting with using TheTVDB as a database. I understand that this is simply disregarding the issue rather than fixing it, and that people may not want to rely on closed source software, but I am a pragmatist and would always choose something that works reasonably well. In the future, I do intend on I apologise for the digression - GitHub issues are supposed to be technical in nature. As it happens, I read your comment on the issue above and merely wanted to point out a workaround that, whilst not ideal, does work rather well. |
You might also want to take a look at Shoko Server - it builds a database of your library using hashes that it compares to AniDB's hash database, and then supplies the metadata to Jellyfin using the Shokofin plugin. |
This isn't really supported by jellyfin. Either you use what it guesses (probably in the resolver? didn't search for that yet) or the plugin needs to overwrite it unconditionally. That's doable in case of normal episodes, but it won't work in the case where AniDB classifies it as a special but you want to have it in its own season. There is no checkbox to lock episode information as far as I can see. It would be possible to add yet another two provider IDs which then get copied into the season/episode fields, but that's a pretty ugly workaround. Especially if you want to use multiple plugins and they are all fighting each other because the providers don't agree on the structure. It's also a huge pain to actually use such a feature. At least better than actually renaming files and loosing all metadata in the process, but it still takes a long time if you need to do multiple times and even worse if there are multiple providers.
I am not too sure about the resolver feature tbh. You can already achieve all of that with renaming/linking the files and there are tools for that. In my opinion the bigger issue is how seasons/specials work in jellyfin and anime usually has way too many special cases for mapping it automatically. Grouping related specials into their own jellyfin seasons (instead of a single 100+ epsiode specials category) would be very helpful and the same goes for grouping related "series"/"seasons" into a single jellyfin series (which makes the single shared specials category issue much worse!). |
Related OVAs/series/seasons can be automatically fetched from https://github.com/Anime-Lists/anime-lists. |
The odd special? It's not niche at all to have different openings, endings and other bonus PER season. o.O
HAMA + Plex is what I'm escaping from. I also absolutely do not like the outlook of putting all my curation work into a project that is proprietary and locked down by the devs and if it dies, my curation has to be either very portable (and its metadata) or I have to do a lot of work again. This is why I'm not sitting on the Jellyfin horse. Even if Plex has some ups over Jellyfin here and there, I'd rather know that if Jellyfin devs give up, anyone can pick it up again and probably existing users' metadata along with it. As for HAMA... Well... no matter how good or not too good it is about looking up info (for specials I found it very lackluster), in the end as it is now both Plex and Jellyfin both have the specials per series, not season constraint and that's quite the kicker.
See above. I've not been too happy with it. Could it be we both value specials very differently? LIkely neatly sorted and displayed OPs and EDs along with the anime, etc... a bit of a structured "Blu-Ray" experience, where the specials actually reside next to the actual season? Also I really like my media manager "guiding" my viewing experience, so I VERY welcome it using all the meta data available reliably to display stuff as orderly as possible. I'm very much the "anti-filesystem" person for viewing experiences. I guess if you don't mind this and you use JF like a filesystem on stereoids (visually) then having one folder for specials per show is fine I guess? Along with poorly extracted titles that are only based on file names, because the plugin couldn't match it to anything. (without a renaming orgy)
Pragmatically I just choose to raise awareness for a complete lack of proper anime support for its intricacies so the issue is tackled for now and the future and ideally for other projects to copy the concept that anime is not "just Japanese media that is kinda like generic media".
The more work is put into good matching media to anidb the better. |
Tried it out, I find working with it a bit cumbersome. I like its approach absolutely, but there doesn't seem to be an easy way to view all unmatched and then manually assigning IDs? IMHO... the lookup is the least of my worries. If I had to use a form view to assign files an anidb ID or something and then hit "apply" I'd be game. Anyhow... I'd still like to work that way, because I can check and verify everything that comes in and then safely know stuff stays the way I intend it to stay. I know I can do that now with using just local metadata, but then I still need something like Shoko, which I tried and didn't find very easy to work with for myself. Maybe I didn't try enough, because as long as specials are per show not per season I honestly don't REALLY put in the effort, not gonna lie. |
I honestly don't want to ever use multiple providers again, it's just headaches all over. I'd rather stick to whatever anidb structure there is and if I completely hate it have a way to overwrite manually. |
I did play around with writing my own plugin for a bit. It works like this at the moment:
It definitely isn't efficient and not as flexible as I wish, but it works. You can build the following structures:
The main limitations in Jellyfin core I encountered so far:
There are still a few things left to do and I am not sure yet if I really want to go that way or if I should simply keep my anime collection outside Jellyfin. Regarding AniDB: Their API is a huge pain, seriously. Finally: Maybe we should move these discussions somewhere else? They are no longer really related to this plugin. |
Could you clarify what those term "Jellyfin season", "provider season" and "series" mean? To my knowledge, AniDB doesn't have seasons - just series entries.
If you don't mind my asking about it, how would you organise your anime collection if you decide to not use Jellyfin?
Agreed - I apologise for bringing this up here. I do want to continue discussing this with @GlassedSilver. I've clearly misunderstood some of your statements, and didn't express my views as clearly as I should have. Please let me know if you can think of a suitable forum to talk about this. |
Hey guys, There are still some things that could be worked on, but the most important things are here and working so I think we should close this issue. Here are some things that could still be added:
If you want any of these implemented or have another problem, make a new issue or message me, then we can work on it. |
I'm a Shoko user now, but to integrate more than EPs and SPs natively could still be very helpful, even for Shoko users I think. If Shoko OR anidb can pass the type of a media item as OP, ED, then JF could then display them as such and use them accordingly. OPs and EDs right now are set as animated backdrops in the Shoko plugin, which is cool, but to just list them as OPs and EDs and then having a JF-native setting to (anime or not, you could adapt this to work in non-anime libs as well after all!) use those medias as backdrops in ADDITION to having them show in specials, that could be great. Not covered by Shoko or anidb: BD menu files. I love them, they too would make for very good backdrops, but I'd love to keep them in Extras as well. Parsing them, probably without metadata scraping if needed, since there's no source for metadata, based on common filenames would be very beneficial as well. Multi-EP files are an issue outside of anime as well. I've split and remerged endings and openings to an entire season of Spongebob so I could Trakt.tv track them and honestly just enjoy a native feel to the library... Well... It's been QUITE the work. All releases like on DVD always piece together those 11-12 min EPs into a single typical 25min-run combined EP. But metadata agents don't work that way. |
I noticed this plugin does not provide jellyfin with unique episode id for anidb, other providing sources like tvdb/imdb/tvmaze etc provide the ids, is there a reason why anidb plugin cant do the same ? example episode link https://anidb.net/episode/253395 |
I haven't used episode ids and didn't find docs or an example implementation quickly, so I haven't added it yet. Providing the episode id to jellyfin should be pretty easy, I'll look into it tomorrow. I believe, you should also be able to input the episode id and the plugin gets the episode metadata from that. Implementing this is more work, and I need to check the AniDB API to find out how to get the metadata for an episode id. |
Back when I played around with it, I couldn't find a way to do anything with just the episode id. You need the anime id to get data from the API and then you can use the episode id to search within the response. |
@nalsai Thank you for your fast response. When can we expect the changes to be publicly avaliable i.e. release channel |
It's going to be available once #33 gets merged by a maintainer. |
Thanks, i was just wondering, |
Also see: jellyfin-archive/jellyfin-plugin-anime#47
I am on Jellyfin 10.7 with the old anime plugin deactivated.
The text was updated successfully, but these errors were encountered: