Why are there long underscores before the names in the output code?

[lissettecarlr]

Input a segment：

{feed:l,reset:o}

output a segment：

feed: ________________________________________________________________handleTextInput,
reset: initializeInputState,

[0xdevalias]

I would suspect that there were a lot of name clashes, and this safe rename code is what's doing it:

humanify/src/plugins/local-llm-rename/visit-all-identifiers.ts

Lines 42 to 54 in 7b85f9d

	const renamed = await visitor(smallestScopeNode.name, surroundingCode);
	if (renamed !== smallestScopeNode.name) {
	let safeRenamed = toIdentifier(renamed);
	while (
	renames.has(safeRenamed) ||
	smallestScope.scope.hasBinding(safeRenamed)
	) {
	safeRenamed = `_${safeRenamed}`;
	}
	renames.add(safeRenamed);
	smallestScope.scope.rename(smallestScopeNode.name, safeRenamed);
	}

Some past discussion related to this feature here as well:

• Syntax Error on Babel? #117 (comment)

Instead of just prefixing with _ each time there is a clash, it might be better to generate some kind of suffix like foo$1, foo$2, etc; which has also been mentioned in the past:

• Error while renaming a variable. (TypeError: Duplicate declaration) #67 (comment)

And some other related issues/PRs:

• Fix "Duplicate declaration" crash #164

Also.. off the top of my head.. since we're tracking renames against the entire program, rather than just per scope, it means that if there is a similarly named variable anywhere in the program, it will be disallowed, and thus get an extra _ prefix.

humanify/src/plugins/local-llm-rename/visit-all-identifiers.ts

Line 20 in 7b85f9d

const renames = new Set<string>();

humanify/src/plugins/local-llm-rename/visit-all-identifiers.ts

Line 51 in 7b85f9d

renames.add(safeRenamed);

While this can obviously make it easier to not have to think about scope rules/shadowing while quickly skimming through a file, in cases like this, it clearly makes things worse. This issue is tangentially related to that area of the code:

• Refactor visitAllIdentifiers to leverage babel's built in scope tracking better #330

[lissettecarlr]

Thank you for your reply.
I checked the source code and indeed found numerous variables with the same character names. The main issue is that the single-page code is too long, causing the underscores to stack up infinitely.

[0xdevalias]

It might be worth leaving this issue open as a reminder that we could improve this based on some of the notes above.