fix: invalid identifiers

jehna · Sep 28, 2024 · cb4ea98 · cb4ea98
1 parent 64a1b95
commit cb4ea98
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/plugins/local-llm-rename/visit-all-identifiers.test.ts b/src/plugins/local-llm-rename/visit-all-identifiers.test.ts
@@ -207,3 +207,10 @@ e.b;
     })
   );
 });
+
+test("should handle invalid identifiers", async () => {
+  const result = await visitAllIdentifiers("const a = k.length;", () =>
+    Promise.resolve("this.kLength")
+  );
+  assert.equal(result, "const thisKLength = k.length;");
+});
diff --git a/src/plugins/local-llm-rename/visit-all-identifiers.ts b/src/plugins/local-llm-rename/visit-all-identifiers.ts
@@ -1,6 +1,6 @@
 import { parseAsync, transformFromAstAsync, NodePath } from "@babel/core";
 import * as babelTraverse from "@babel/traverse";
-import { Identifier, isValidIdentifier, Node } from "@babel/types";
+import { Identifier, toIdentifier, Node } from "@babel/types";
 
 const traverse: typeof babelTraverse.default.default = (
   typeof babelTraverse.default === "function"
@@ -41,7 +41,7 @@ export async function visitAllIdentifiers(
     const surroundingCode = await scopeToString(smallestScope);
     const renamed = await visitor(smallestScopeNode.name, surroundingCode);
 
-    let safeRenamed = isValidIdentifier(renamed) ? renamed : `_${renamed}`;
+    let safeRenamed = toIdentifier(renamed);
     while (renames.has(safeRenamed)) {
       safeRenamed = `_${safeRenamed}`;
     }