Skip to content

Commit 144ea68

Browse files
authored
Use string key if getRangeBuffer is available (#4)
1 parent 4b0b615 commit 144ea68

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

lib/redis-rstream.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function RedisRStream(client, key, options) {
1414
if (!(this instanceof RedisRStream)) return new RedisRStream(client, key, options);
1515
Readable.call(this, options);
1616
this._redisClient = client;
17-
this._redisKey = new Buffer(key); // using Buffer key so redis returns buffers
17+
this._redisKey = !!client.getrangeBuffer ? key : new Buffer(key); // using Buffer key so redis returns buffers
1818
this._redisChunkSize = (options && options.chunkSize) ? options.chunkSize : 64 * 1024; // default 64KB
1919
this._redisMaxPendingReads = (options && options.maxPendingReads) ? options.maxPendingReads : 2;
2020
this._redisOffset = (options && options.startOffset) ? options.startOffset : 0;
@@ -23,7 +23,6 @@ function RedisRStream(client, key, options) {
2323
this._redisLength = 0;
2424
this._redisEnded = false;
2525
this._redisPendingReads = 0;
26-
this._redisHasSuffixBufferAPI = !!client.getrangeBuffer
2726
}
2827

2928
util.inherits(RedisRStream, Readable);
@@ -70,7 +69,7 @@ RedisRStream.prototype._read = function _read(size) {
7069
return;
7170
}
7271
};
73-
if (this._redisHasSuffixBufferAPI) {
72+
if (self._redisClient.getrangeBuffer) {
7473
self._redisClient.getrangeBuffer(self._redisKey, startOffset, endOffset, getrangeCallback)
7574
} else {
7675
self._redisClient.getrange(self._redisKey, startOffset, endOffset, getrangeCallback)

0 commit comments

Comments
 (0)