From 1a7a2d2e456be4b237e77e49a6240823be74b6dc Mon Sep 17 00:00:00 2001 From: rolv Date: Sat, 16 Nov 2024 14:50:54 +0000 Subject: [PATCH 1/3] ci: include newer versions of `languagetool` in tests --- .github/workflows/rustlib.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rustlib.yml b/.github/workflows/rustlib.yml index 13b9422..5b3eab6 100644 --- a/.github/workflows/rustlib.yml +++ b/.github/workflows/rustlib.yml @@ -30,7 +30,7 @@ jobs: strategy: fail-fast: false matrix: - tag: [latest, '5.5', '5.6', '5.7', '5.8', '5.9', '6.0', '6.1'] + tag: [latest, '5.5', '5.6', '5.7', '5.8', '5.9', '6.0', '6.1', '6.2', '6.3', '6.4', '6.5'] runs-on: ubuntu-latest services: languagetool: From a800a4c4e163d16efc080619ca2a8ac2de91c50c Mon Sep 17 00:00:00 2001 From: rolv Date: Sat, 16 Nov 2024 15:42:33 +0000 Subject: [PATCH 2/3] tests: debug errors with server testing --- src/api/server.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/api/server.rs b/src/api/server.rs index 495d380..383eb1e 100644 --- a/src/api/server.rs +++ b/src/api/server.rs @@ -594,19 +594,23 @@ impl ServerClient { #[cfg(test)] mod tests { use super::ServerClient; - use crate::api::check::Request; + use crate::{api::check::Request, error}; + + fn dbg_err(e: &error::Error) { + eprintln!("Error: {e:?}") + } #[tokio::test] async fn test_server_ping() { let client = ServerClient::from_env_or_default(); - assert!(client.ping().await.is_ok()); + assert!(client.ping().await.inspect_err(dbg_err).is_ok()); } #[tokio::test] async fn test_server_check_text() { let client = ServerClient::from_env_or_default(); let req = Request::default().with_text("je suis une poupee"); - assert!(client.check(&req).await.is_ok()); + assert!(client.check(&req).await.inspect_err(dbg_err).is_ok()); } #[tokio::test] @@ -615,12 +619,12 @@ mod tests { let req = Request::default() .with_data_str("{\"annotation\":[{\"text\": \"je suis une poupee\"}]}") .unwrap(); - assert!(client.check(&req).await.is_ok()); + assert!(client.check(&req).await.inspect_err(dbg_err).is_ok()); } #[tokio::test] async fn test_server_languages() { let client = ServerClient::from_env_or_default(); - assert!(client.languages().await.is_ok()); + assert!(client.languages().await.inspect_err(dbg_err).is_ok()); } } From 4838e40e5ea096994614889df583fe96ce3ff820 Mon Sep 17 00:00:00 2001 From: rolv Date: Sat, 16 Nov 2024 15:43:24 +0000 Subject: [PATCH 3/3] ci: `--no-capture` for testing library code, for easier debugging failing CI tests --- .github/workflows/rustlib.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rustlib.yml b/.github/workflows/rustlib.yml index 5b3eab6..87e6470 100644 --- a/.github/workflows/rustlib.yml +++ b/.github/workflows/rustlib.yml @@ -51,4 +51,4 @@ jobs: uses: Swatinem/rust-cache@v2 - run: curl -LsSf https://get.nexte.st/latest/linux | tar zxf - -C ${CARGO_HOME:-~/.cargo}/bin - - run: cargo nextest run --all-features + - run: cargo nextest run --all-features --no-capture