Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate oasis-align-images logic into oasis-align #11

Open
jdpieck opened this issue Dec 1, 2024 · 0 comments
Open

Integrate oasis-align-images logic into oasis-align #11

jdpieck opened this issue Dec 1, 2024 · 0 comments

Comments

@jdpieck
Copy link
Owner

jdpieck commented Dec 1, 2024

oasis-align-images uses an equation to find the ideal fraction for two pieces of content with fixed aspect ratios. This means that content can be perfectly aligned, while oasis-align is only able to get a solution within tolerance.

By starting the oasis-align parameter fraction at the point calculated using oasis-align-images, fixed aspect ratio content will automatically be aligned while still allowing for other kinds of content to be aligned.

(Thanks to @Aaron-Rumpler for the suggestion!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant