Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CSS3 Transitions #9

Open
jdan opened this issue Jun 9, 2012 · 3 comments
Open

Migrate to CSS3 Transitions #9

jdan opened this issue Jun 9, 2012 · 3 comments

Comments

@jdan
Copy link
Owner

jdan commented Jun 9, 2012

The effect lags quite heavily on iOS devices, and I'm not sure why. Maybe we should think about CSS3 transition for some cases, since hardware acceleration is applied to CSS3 on iOS.

CSS3 transitions also have other benefits, namely simplicity.

@xtagon
Copy link

xtagon commented Apr 21, 2013

I've started work on this but ran into a snag. The text transitions out, but is not replaced because the transitionend event is seemingly not firing. Could you take a look? 357c529

Once it is working, it should fall back to the JQuery slide when no transitionOut option is specified.

@jdan
Copy link
Owner Author

jdan commented Apr 21, 2013

Thanks for taking a stab at this, I like the way you engineered this.

The first thing I found was that giving class="dynamo" AND calling .dynamo() results in issues. I don't think that's causing your problems, but just a heads up (I should probably fix this behavior)

Doing the following:

el.bind('webkitAnimationEnd', function() {
    console.log('transition ended');
}); // FIXME

Produces console output. I'm not sure why webkitTransitionEnd fails, but I know that webkitAnimationEnd works. This might not fix your problem, though. I don't know much about CSS3 transitions and their events. Throwing onDone there transitions, but the behavior is wonky.

@xtagon
Copy link

xtagon commented Apr 21, 2013

You're right, I should have been using animationend instead of transitionend! I was also forgetting to remove the animation classes after it completed. My branch has been updated accordingly.

There is another quirk: the fadeOutUp animation doesn't look right because of how the element is nested in it's parent. The animation should look like the element fading up and out, but it is is clipped by the parent's border. So it's more like a fading slide now. I'm not sure how to go about fixing that, but we should test other animate.css classes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants