Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept username in ProjectMembers#add #3666

Merged

Conversation

talyssonoc
Copy link
Contributor

Fix #3665

@jdalrymple
Copy link
Owner

Ill switch up the name of the argument to be a bit more descriptive, but looks good otherwise!

@jdalrymple jdalrymple added the breaking Changes are not backwards compatible label Dec 31, 2024
@jdalrymple jdalrymple merged commit 5d86207 into jdalrymple:main Dec 31, 2024
1 check passed
jdalrymple added a commit that referenced this pull request Dec 31, 2024
@jdalrymple
Copy link
Owner

🚀 PR was released in 42.0.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Dec 31, 2024
@talyssonoc
Copy link
Contributor Author

Thank you, @jdalrymple!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes are not backwards compatible released This issue/pull request has been released. type:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProjectMembers#add should accept username if user_id is not provided
2 participants