fix: normalize empty/whitespace to null

Author: jedwards1211

.flowconfig

@@ -1,6 +1,7 @@
 [ignore]
 <PROJECT_ROOT>/node_modules/fbjs/.*
 <PROJECT_ROOT>/node_modules/.*/tests?/.*\.json
+<PROJECT_ROOT>/node_modules/immutable/dist/immutable.js.flow
 <PROJECT_ROOT>/lib
 
 [include]

package.json

@@ -91,6 +91,7 @@
     "istanbul": "^0.4.5",
     "jsdom": "^11.5.1",
     "jsdom-global": "^3.0.2",
+    "lodash.get": "^4.4.2",
     "mocha": "^4.1.0",
     "nyc": "^11.4.1",
     "react": "^16.2.0",

src/createNumericField.js

@@ -13,9 +13,8 @@ function createNumericField<P: React.ElementProps<Field>>(
   type Props = React.ElementProps<typeof Field> & {normalizeNumber?: NumberNormalizer}
 
   function defaultNormalize(value: ?(string | number)): ?(string | number) {
-    if (value == null || typeof value === 'number' || WHITESPACE.test(value)) {
-      return typeof value === 'string' ? value.trim() : value
-    }
+    if (value == null || WHITESPACE.test((value: any))) return null
+    if (typeof value === 'number') return value
     const parsed = Number(value)
     return Number.isFinite(parsed) ? parsed : value.trim()
   }

test/index.js

@@ -1,6 +1,8 @@
 // @flow
 
 import * as React from 'react'
+import get from 'lodash.get'
+import {Iterable} from 'immutable'
 import {describe, it} from 'mocha'
 import {createStore, combineReducers} from 'redux'
 import {Provider} from 'react-redux'
@@ -26,6 +28,10 @@ function max(threshold: number): (value: number) => ?string {
   }
 }
 
+function getIn(obj: any, path: any): any {
+  return Iterable.isIterable(obj) ? obj.getIn(path) : get(obj, path)
+}
+
 describe('NumericField', () => {
   function tests({NumericField, reducer, reduxForm}: any) {
     it('normalizes valid number on blur', () => {
@@ -102,6 +108,7 @@ describe('NumericField', () => {
       comp.update().find(Input).simulate('blur')
       expect(comp.update().find('input').prop('value')).to.equal('')
       expect(comp.update().find(Input).prop('meta').error).not.to.exist
+      expect(getIn(store.getState().form, ['form', 'values', 'hello'])).to.equal(null)
     })
     it('supports single validate function', () => {
       const store = createStore(combineReducers({form: reducer}))

yarn.lock

@@ -4020,6 +4020,10 @@ lodash.flattendeep@^4.4.0:
   version "4.4.0"
   resolved "https://registry.npmjs.org/lodash.flattendeep/-/lodash.flattendeep-4.4.0.tgz#fb030917f86a3134e5bc9bec0d69e0013ddfedb2"
 
+lodash.get@^4.4.2:
+  version "4.4.2"
+  resolved "https://registry.npmjs.org/lodash.get/-/lodash.get-4.4.2.tgz#2d177f652fa31e939b4438d5341499dfa3825e99"
+
 [email protected]:
   version "4.1.1"
   resolved "https://registry.npmjs.org/lodash.kebabcase/-/lodash.kebabcase-4.1.1.tgz#8489b1cb0d29ff88195cceca448ff6d6cc295c36"