fix: check TSImportType nodes

Author: jedwards1211

eslint.config.test.cjs

@@ -35,5 +35,22 @@ module.exports = [
         ],
       },
     },
+    {
+      ...tseslint.configs.base,
+      files: ['fixture/**/typesNotIgnored.ts'],
+      plugins: {
+        '@jcoreio/implicit-dependencies': require('./src/index'),
+      },
+      rules: {
+        '@jcoreio/implicit-dependencies/no-implicit': [
+          2,
+          {
+            dev: true,
+            ignore: ['blaz', '@ack/glom'],
+            ignoreTypeOnlyImports: false,
+          },
+        ],
+      },
+    },
   ]),
 ]

fixture/index.ts

@@ -37,4 +37,7 @@ import type {blag} from 'blag'
 // @ts-expect-error missing dep
 import {type floom, type flam} from 'floom'
 // @ts-expect-error missing dep
-import {type glarb, blorgh} from 'glarb'
+import {type glarb, blorgh} from 'glarb'
+
+// @ts-expect-error missing dep
+type X = import('bloop')

fixture/typesNotIgnored.ts

@@ -0,0 +1,43 @@
+/* eslint-env commonjs */
+
+require('foo')
+import 'bar'
+import 'pkg-up'
+// @ts-expect-error missing dep
+import('qux/gloob')
+// @ts-expect-error missing dep
+export * from 'blonk'
+// @ts-expect-error missing dep
+export { blark } from 'blark'
+require('@a/b/c')
+
+require('!!raw-loader!./foo/bar')
+require('_a-b')
+require('AB')
+
+import 'process'
+import 'fs/promises'
+import 'node:process'
+import '@jcoreio/toolchain'
+
+import '@jcoreio/eslint-plugin-implicit-dependencies'
+
+const foo = 1
+export { foo }
+
+export default foo
+
+export class Bar {}
+
+import 'blaz'
+import '@ack/glom/flark'
+
+// @ts-expect-error missing dep
+import type {blag} from 'blag'
+// @ts-expect-error missing dep
+import {type floom, type flam} from 'floom'
+// @ts-expect-error missing dep
+import {type glarb, blorgh} from 'glarb'
+
+// @ts-expect-error missing dep
+type X = import('bloop')

src/rules/no-implicit-dependencies.js

@@ -128,6 +128,12 @@ export default {
         const name = node.source?.value
         checkModuleName(name, node)
       },
+      'TSImportType:exit': (node) => {
+        const name = (node.parameter || node.argument)?.literal.value
+        if (!context.options[0]?.ignoreTypeOnlyImports) {
+          checkModuleName(name, node)
+        }
+      },
     }
   },
 }

test/index.js

@@ -9,6 +9,7 @@ import execa from '@jcoreio/toolchain/util/execa.cjs'
 import dedent from 'dedent-js'
 
 it(`works`, async function () {
+  this.timeout(10000)
   expect(
     (
       await execa(
@@ -36,7 +37,19 @@ it(`works`, async function () {
       12:1  error  Module "@a/b" is not listed as a dependency in package.json   @jcoreio/implicit-dependencies/no-implicit
       40:1  error  Module "glarb" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
 
-    ✖ 13 problems (13 errors, 0 warnings)
+    ${process.cwd()}/fixture/typesNotIgnored.ts
+       3:1   error  Module "foo" is not listed as a dependency in package.json    @jcoreio/implicit-dependencies/no-implicit
+       4:1   error  Module "bar" is not listed as a dependency in package.json    @jcoreio/implicit-dependencies/no-implicit
+       7:1   error  Module "qux" is not listed as a dependency in package.json    @jcoreio/implicit-dependencies/no-implicit
+       9:1   error  Module "blonk" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
+      11:1   error  Module "blark" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
+      12:1   error  Module "@a/b" is not listed as a dependency in package.json   @jcoreio/implicit-dependencies/no-implicit
+      36:1   error  Module "blag" is not listed as a dependency in package.json   @jcoreio/implicit-dependencies/no-implicit
+      38:1   error  Module "floom" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
+      40:1   error  Module "glarb" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
+      43:10  error  Module "bloop" is not listed as a dependency in package.json  @jcoreio/implicit-dependencies/no-implicit
+
+    ✖ 23 problems (23 errors, 0 warnings)
   `.trim()
   )
 })