Allow Pirate Weather API

[Robert-litts]

Good Morning,

Just wanted to start off by saying I love this module and have been using it (and previously, Dark Sky Forecast) for years. It is a staple of all my MM setups.

I have an old API Key for Open Weather Forecast so I have never had issues with my personal setup, but recently have been building a few new MagicMirrors for friends & came upon the change to the Open Weather 'One Call 3.0' API, which now requires a credit card. I realize that you can manually set a limit to prevent being charged, but there are alternative which seem more reasonable to use.

I know that Pirate Weather is now included in the default config for MM's weather, and signing up is free & seems to be almost a direct replacement for Dark Sky's API. However, the change a few years back to OpenWeather means that simply changing the API in the node_helper.js is not sufficient.

I am not very familiar with module development, but I am happy to help try to contribute to a PR to update the OpenWeatherForecast module to allow an option to use Pirate Weather as an alternative to OpenWeather. I know that @dankerthrone created PR #38 on your MMM-DarkSkyForecast, and then subsequently forked it into MMM-PirateSkyForecast, but that module is based on MMM-DarkSkyForecast which is using outdated code, and I believe a fork of MMM-OpenWeatherForecast makes more sense.

In my initial attempts, I changed the API to use Pirate Weather in node_helper.js, but that was not enough & the module doesn't display properly. Hopefully I possibly get a bit of guidance or assistance on where else to update in order to push this in the right direction.

Thank you!

[dankerthrone]

Hey man, unfortunately I really have no idea what I'm doing here and therefore can't really assist. However, if it's true that MMM-Darkskyforecast is using outdated code, that would explain why my own fork of it doesn't really work. I'd be really happy if someone cobbled together a functioning version of DarkSkyForecast/OpenWeatherForecast using the PirateWeather API, as @jclarke0000's version is just so dang eye-catching and clean and customizable.

Unfortunately, I can't really help on this one :(