Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for skipping tools.go #5

Open
jcchavezs opened this issue May 21, 2021 · 4 comments
Open

Adds support for skipping tools.go #5

jcchavezs opened this issue May 21, 2021 · 4 comments

Comments

@jcchavezs
Copy link
Owner

Currently files like tools.go or or including // +build tools should be skipped.

@jcchavezs
Copy link
Owner Author

Actually we should be able to skip specific +build tags instead of arbitrary support tools only.

@jcchavezs
Copy link
Owner Author

I'd really like to hear your feedback on this one @mx-psi

@mx-psi
Copy link
Contributor

mx-psi commented Oct 12, 2021

Having the ability to filter by build tags sounds like a good idea, but I am not sure what is the best default for this: I don't love golangci-lint default behavior of excluding everything (e.g. I feel like build tags like windows should be included by default)

@jcchavezs
Copy link
Owner Author

I think in this case we should do denylist instead of allowlist. Maybe not the most popular choice but in general you only want to exclude from vanity import either autogenerated files or tools in which case ignoring a build tag would do the trick. Remember it is also a common practice adding a build tag for ignoring files as part of the compilation and dependency resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants