-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for skipping tools.go #5
Comments
Actually we should be able to skip specific |
I'd really like to hear your feedback on this one @mx-psi |
Having the ability to filter by build tags sounds like a good idea, but I am not sure what is the best default for this: I don't love golangci-lint default behavior of excluding everything (e.g. I feel like build tags like |
I think in this case we should do denylist instead of allowlist. Maybe not the most popular choice but in general you only want to exclude from vanity import either autogenerated files or tools in which case ignoring a build tag would do the trick. Remember it is also a common practice adding a build tag for ignoring files as part of the compilation and dependency resolution. |
Currently files like tools.go or or including
// +build tools
should be skipped.The text was updated successfully, but these errors were encountered: