WarFileTest.checkEbextensionsValidityThrowsExceptionNoDir broken.

[nhekfqn]

That test does not actually check that exception is thrown. If no exception is thrown, assert will not be called and test will pass.

@Test
    public void checkEbextensionsValidityThrowsExceptionNoDir()
        throws IOException {
        final ZipFile zip = Mockito.mock(ZipFile.class);
        Mockito.when(zip.getEntry(".ebextensions")).thenReturn(null);
        final WarFile war = new WarFile(zip);
        try {
            war.checkEbextensionsValidity();
        } catch (final MojoFailureException exception) {
            MatcherAssert.assertThat(
                exception.getMessage(),
                Matchers.equalTo(
                    ".ebextensions directory does not exist in the WAR file"
                )
            );
        }

[dmarkov]

I am aware of the task, give me some time to find a developer...

[dmarkov]

@nhekfqn many thanks, 15 mins added to your acc for reporting this bug, pmt ID 51683468

[nhekfqn]

@dmarkov Can I ask to assign this to me?

[dmarkov]

@apocarteres the issue is yours, please help

[dmarkov]

@tmjee the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here... This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

[tmjee]

@dmarkov fixed in pull request #29

[tmjee]

@nhekfqn Merged. Pls close this issue. Thx

[dmarkov]

@dmarkov fixed in pull request #29

@tmjee OK thanks

[dmarkov]

@prondzyn it's your task, go ahead

[prondzyn]

@dmarkov I reviewed history of this task, PR, and source code and this issue is already fixed adding extra checking.

Please see line: https://github.com/jcabi/jcabi-beanstalk-maven-plugin/blob/master/src/test/java/com/jcabi/beanstalk/maven/plugin/GenericMojoTest.java#L178

In meanwhile the problematic test was renamed and moved to GenericMojoTest class.

I will ask task author to close this ticket.

[prondzyn]

@nhekfqn please close the issue. It was already fixed in PR #29.

[prondzyn]

@nhekfqn ping

[prondzyn]

@dmarkov looks like author of this task is no longer active on GitHub - zero commits through last year. But the issue is fixed as I mentioned before. Can you close the task or do something about it?

[prondzyn]

@nhekfqn I'm asking once again, please close the issue. It was already fixed in PR #29.

[prondzyn]

@dmarkov still does not respond. What should I do with this task?

[dmarkov]

@dmarkov looks like author of this task is no longer active on GitHub - zero commits through last year. But the issue is fixed as I mentioned before. Can you close the task or do something about it?

@prondzyn sure

[prondzyn]

@dmarkov can you close the task?

[dmarkov]

@prondzyn this task is in your hands for 16 days already

added -30 to your rating, now it is equal to +60

[prondzyn]

@dmarkov why? I was asking you 10 days ago about closing this task:

@dmarkov looks like author of this task is no longer active on GitHub - zero commits through last year. But the issue is fixed as I mentioned before. Can you close the task or do something about it?

@prondzyn sure

[prondzyn]

@dmarkov please close the task

[dmarkov]

@dmarkov please close the task

@prondzyn thanks

[dmarkov]

@prondzyn the task is overdue, and I have to re-assign it to someone else. Please, stop working with it immediately. In general, we're against overdue tasks, check this page... -60 to your rating, your total score is -30

[prondzyn]

@dmarkov this stinks. @yegor256 I know that you will say same as @dmarkov but please review history of this task and my comments. I reviewed it and contacted with an author but he is no longer active. I know the "no obligations" and other rules but there are some lack with them in some cases. Think about it.

[dmarkov]

@dmarkov this stinks. @yegor256 I know that you will say same as @dmarkov but please review history of this task and my comments. I reviewed it and contacted with an author but he is no longer active. I know the "no obligations" and other rules but there are some lack with them in some cases. Think about it.

@prondzyn @yegor256 could you please help us here?